Add Dell Enterprise Sonic-CLI driver

This driver uses the sonic-cli rather than Linux userspace to
configure the switch. This is because LLDP advertises switch
ports based on the naming from the sonic-cli, which is not the
same as Linux userspace.

There remains an exercise to push this upstream. Note the existing
Dell Sonic driver on main is using the Linux namespace netmiko
driver, which is not suitable [1].

[1] https://github.com/openstack/networking-generic-switch/tree/master/networking_generic_switch/devices/netmiko_devices

Author: dougszumski

networking_generic_switch/devices/netmiko_devices/dell.py

@@ -133,6 +133,70 @@ class DellNos(netmiko_devices.NetmikoSwitch):
     )
 
 
+class DellEnterpriseSonicCli(netmiko_devices.NetmikoSwitch):
+    """Netmiko device driver for Dell Enterprise switches.
+
+       Developed against SONiC-OS-4.2.3-Edge_Standard.
+
+       This driver uses the sonic-cli rather than Linux userspace to
+       configure the switch. This is because LLDP advertises switch
+       ports based on the naming from the sonic-cli, which is not the
+       same as Linux userspace.
+    """
+
+    NETMIKO_DEVICE_TYPE = "dell_sonic_ssh"
+
+    ADD_NETWORK = (
+        'interface vlan {segmentation_id}',
+    )
+
+    DELETE_NETWORK = (
+        'no interface vlan {segmentation_id}',
+    )
+
+    PLUG_PORT_TO_NETWORK = (
+        'interface {port}',
+        'switchport access vlan {segmentation_id}',
+    )
+
+    DELETE_PORT = (
+        'interface {port}',
+        'no switchport access vlan',
+    )
+
+    SAVE_CONFIGURATION = (
+        'copy running-configuration startup-configuration',
+    )
+
+    # TODO(dougszu): We need some typical failures to add here
+    ERROR_MSG_PATTERNS = []
+
+    def save_configuration(self, net_connect):
+        """Try to save the device's configuration.
+
+        :param net_connect: a netmiko connection object.
+        """
+        # NOTE(dougszu): We override this because they default
+        # method tries 'copy running-config startup-config' which
+        # is transformed by the switch to:
+        # 'copy running-configuration startup-configuration'.
+        for cmd in self.SAVE_CONFIGURATION:
+            net_connect.send_command(cmd)
+
+    def send_config_set(self, net_connect, cmd_set):
+        """Send a set of configuration lines to the device.
+
+        :param net_connect: a netmiko connection object.
+        :param cmd_set: a list of configuration lines to send.
+        :returns: The output of the configuration commands.
+        """
+        net_connect.enable()
+        # NOTE(dougszu): We override this so that we wait for commands
+        # to run before moving on.
+        return net_connect.send_config_set(config_commands=cmd_set,
+                                           cmd_verify=True)
+
+
 class DellPowerConnect(netmiko_devices.NetmikoSwitch):
     """Netmiko device driver for Dell PowerConnect switches."""
 

setup.cfg

@@ -38,6 +38,7 @@ generic_switch.devices =
     netmiko_huawei_vrpv8 = networking_generic_switch.devices.netmiko_devices.huawei_vrpv8:Huawei
     netmiko_arista_eos = networking_generic_switch.devices.netmiko_devices.arista:AristaEos
     netmiko_dell_os10 = networking_generic_switch.devices.netmiko_devices.dell:DellOS10
+    netmiko_dell_enterprise_sonic_cli = networking_generic_switch.devices.netmiko_devices.dell:DellEnterpriseSonicCli
     netmiko_dell_force10 = networking_generic_switch.devices.netmiko_devices.dell:DellNos
     netmiko_dell_powerconnect = networking_generic_switch.devices.netmiko_devices.dell:DellPowerConnect
     netmiko_brocade_fastiron = networking_generic_switch.devices.netmiko_devices.brocade:BrocadeFastIron