Fix functional test failure due to OVN commit

A recent commit to OVN branch-26.03 broke the gate.

  northd: Clear stale LSP tags on tag_request removal.

That patch presumes that tags are set via 'tag_request' which it
looks like we should have been doing all along, but
create_provnet_port() only set the tag directly. In this case,
the tag now gets removed and test_network_segments_localnet_ports
fails.

For now, this patch just adds the tag_request and sets the tag both
because I'm not sure whether there should be any changes to the OVN
patch and because it still works.

Obviously it would also be possible to set a more static OVN target
requiremnt--there are tradeoffs there.

Closes-Bug: #2155789
Change-Id: I0e8b3391ba385bb98af52e153e12cf7372e4bfb5
Signed-off-by: Terry Wilson <twilson@redhat.com>

Author: otherwiseguy

neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py

@@ -2186,6 +2186,7 @@ def create_provnet_port(self, context, network_id, segment, txn=None,
             external_ids={ovn_const.OVN_PHYSNET_EXT_ID_KEY: physnet},
             type=ovn_const.LSP_TYPE_LOCALNET,
             tag=tag,
+            tag_request=tag,
             options=options)
         self._transaction([cmd], txn=txn)
 

neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py

@@ -1034,6 +1034,7 @@ def test_create_network_create_localnet_port_physical_network_type(self):
                     ovs_conf.get_igmp_flood(),
                 ovn_const.LSP_OPTIONS_LOCALNET_LEARN_FDB: 'false'},
             tag=2,
+            tag_request=2,
             type='localnet')
 
     def test_create_port_without_security_groups(self):
@@ -4027,6 +4028,7 @@ def test_create_segment_create_localnet_port(self):
                     ovs_conf.get_igmp_flood(),
                 ovn_const.LSP_OPTIONS_LOCALNET_LEARN_FDB: 'false'},
             tag=200,
+            tag_request=200,
             type='localnet')
         ovn_nb_api.create_lswitch_port.reset_mock()
         physnet2_name = 'physnet2'
@@ -4047,6 +4049,7 @@ def test_create_segment_create_localnet_port(self):
                     ovs_conf.get_igmp_flood(),
                 ovn_const.LSP_OPTIONS_LOCALNET_LEARN_FDB: 'false'},
             tag=300,
+            tag_request=300,
             type='localnet')
         segments = segments_db.get_network_segments(
             self.context, net['id'])