Skip to content

Commit bc586dc

Browse files
authored
Merge pull request #2388 from stackhpc/2026_1_ansible_lint
Make ansible-lint passing for stackhpc/2026.1
2 parents 53c0edd + f781892 commit bc586dc

4 files changed

Lines changed: 11 additions & 5 deletions

File tree

.ansible-lint

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,9 @@ skip_list:
88
- yaml
99
- role-name[path]
1010
- yaml[line-length]
11+
exclude_paths:
12+
# These files use import_playbook with runtime env var lookups (KAYOBE_CONFIG_PATH / VIRTUAL_ENV)
13+
# that cannot be resolved at lint time.
14+
- etc/kayobe/ansible/fixes/fix-hostname.yml
15+
- etc/kayobe/ansible/maintenance/ubuntu-upgrade.yml
16+
- etc/kayobe/ansible/secret-store/vault-bao-migration-all.yml

.github/workflows/stackhpc-pull-request.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,10 +87,10 @@ jobs:
8787
matrix:
8888
include:
8989
# NOTE(upgrade): Keep these in sync with Kayobe's supported Ansible and Python versions (see release notes).
90-
- ansible: "2.18"
90+
- ansible: "2.19"
91+
python: "3.12"
92+
- ansible: "2.20"
9193
python: "3.12"
92-
- ansible: "2.17"
93-
python: "3.10"
9494
name: Ansible ${{ matrix.ansible }} lint with Python ${{ matrix.python }}
9595
if: github.repository == 'stackhpc/stackhpc-kayobe-config'
9696
steps:

etc/kayobe/ansible/tools/get-cloud-facts.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
- name: Check if ngs enabled
77
ansible.builtin.set_fact:
88
ngs_enabled: >-
9-
{{ 'genericswitch' in kolla_neutron_ml2_mechanism_drivers | default(false) }}
9+
{{ 'genericswitch' in kolla_neutron_ml2_mechanism_drivers | default([]) }}
1010
when: kolla_neutron_ml2_mechanism_drivers
1111

1212
- name: Set facts for seed node

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
kayobe@git+https://github.com/stackhpc/kayobe@stackhpc/18.4.0.3
1+
kayobe@git+https://github.com/stackhpc/kayobe@stackhpc/20.0.0.5
22
ansible-modules-hashivault>=5.3.0
33
pulp-glue==0.33.*
44
pulp-glue-deb==0.3.*

0 commit comments

Comments
 (0)