Skip to content

Kolla-Ansible/Kayobe version enforcement#1551

Merged
Alex-Welsh merged 25 commits intostackhpc/2024.1from
check-kayobe-version
May 12, 2025
Merged

Kolla-Ansible/Kayobe version enforcement#1551
Alex-Welsh merged 25 commits intostackhpc/2024.1from
check-kayobe-version

Conversation

@assumptionsandg
Copy link
Copy Markdown
Contributor

@assumptionsandg assumptionsandg commented Mar 3, 2025

No description provided.

@assumptionsandg assumptionsandg requested a review from a team as a code owner March 3, 2025 13:52
@product-auto-label product-auto-label bot added size: m ansible Ansible playbooks labels Mar 3, 2025
Alex-Welsh
Alex-Welsh reviewed Mar 3, 2025
View reviewed changes
@assumptionsandg
Copy link
Copy Markdown
Contributor Author

assumptionsandg commented Mar 3, 2025

Skipping the linter as I don't think it's possible to use git describe as part of the Ansible git module.

Alex-Welsh
Alex-Welsh reviewed Mar 3, 2025
View reviewed changes
@assumptionsandg
Copy link
Copy Markdown
Contributor Author

assumptionsandg commented Mar 5, 2025 •
edited
Loading

Requires pip 24.0 or newer. (precheck added in 88dba74)

assumptionsandg
assumptionsandg commented Mar 5, 2025
View reviewed changes
@mnasiadka
Copy link
Copy Markdown
Member

mnasiadka commented Mar 6, 2025

Out of my curiosity - why are we doing that here jnstead in the Kayobe python CLI?

@assumptionsandg
Copy link
Copy Markdown
Contributor Author

assumptionsandg commented Mar 6, 2025 •
edited
Loading

Out of my curiosity - why are we doing that here jnstead in the Kayobe python CLI?

This is more of a workaround for Kayobe/Kolla CLI version returning a different value from our downstream tagging, which don't follow pbr versioning.

See upstream bug https://bugs.launchpad.net/kayobe/+bug/2101051

@assumptionsandg assumptionsandg changed the title Check Kayobe version playbook Kolla-Ansible/Kayobe version enforcement Mar 6, 2025
jovial
jovial reviewed Mar 6, 2025
View reviewed changes
Alex-Welsh
Alex-Welsh reviewed May 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording could be improved on the release note, but otherwise I'd be happy to merge this. We can always tweak it once it's merged. @jovial is that okay with you?

@assumptionsandg @Alex-Welsh
Apply suggestions from code review
d2609c3 
Co-authored-by: Alex-Welsh <112560678+Alex-Welsh@users.noreply.github.com>
@jovial
Copy link
Copy Markdown
Contributor

jovial commented May 12, 2025

Wording could be improved on the release note, but otherwise I'd be happy to merge this. We can always tweak it once it's merged. @jovial is that okay with you?

Sure, lets give it a whirl and see how well it works.

@Alex-Welsh Alex-Welsh enabled auto-merge (squash) May 12, 2025 10:58
@Alex-Welsh Alex-Welsh merged commit 9202db2 into stackhpc/2024.1 May 12, 2025
16 checks passed
@Alex-Welsh Alex-Welsh deleted the check-kayobe-version branch May 12, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alex-Welsh Alex-Welsh Alex-Welsh left review comments

@jovial jovial jovial approved these changes

Assignees

No one assigned

Labels

ansible Ansible playbooks size: m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@assumptionsandg @mnasiadka @jovial @Alex-Welsh