Add Github CI runner proxy support#1992
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds proxy support for GitHub runners by setting a custom_env fact. The overall approach is good, but there is a critical issue in how the no_proxy variable is constructed which could cause the Ansible playbook to fail. I've provided a suggestion to fix this and make the implementation more robust.
Conditionally define custom_env fact to leverage monolithprojects.github_actions_runner role support for setting proxy on deployed Github runners.
darmach
force-pushed
the
jd-github-ci-proxy
branch
from
6140846 to
6c9662f
Compare
darmach
force-pushed
the
jd-github-ci-proxy
branch
from
2a0ab4e to
8015b5f
Compare
|
Putting into draft, need to rework proxy support in docker role |
Alex-Welsh
added
the
waiting-author-response
|
Happy Friday @darmach, this is a friendly reminder that this PR is waiting for your changes or response. Please take a look when you have a moment! Note: Once your changes are ready, remove the |
1 similar comment
|
Happy Friday @darmach, this is a friendly reminder that this PR is waiting for your changes or response. Please take a look when you have a moment! Note: Once your changes are ready, remove the |
2 participants
Conditionally sets custom_env fact to leverage
monolithprojects.github_actions_runner role support for seting proxy for deployed Github runners.
Confirmed working on environment with mandatory proxy ONLY - it would be great if someone could give this a go in non-proxy setup. With custom_env defined monolithprojects role creates .env file in /opt/actions*... directory (per runner) which is ingested by the running runner (ran on the runner VM ,)