Ubuntu Upgrade Script tweaks#2141
Merged
priteau merged 4 commits intostackhpc/2024.1from Feb 20, 2026
Merged
Conversation
Contributor
jovial
commented
Feb 6, 2026
jovial
commented
- Tweaked ordering to fix various issues
- Added additional tags so that you can resume if something goes wrong
- Tweaked ordering to fix various issues - Added additional tags so that you can resume if something goes wrong
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Ubuntu upgrade playbook by reordering tasks and adding tags, which should make the process more robust and easier to resume on failure. The changes are logical, grouping repository cleanup tasks together. I've added a few suggestions to remove some minor redundancies introduced in the new code, such as an unnecessary loop and duplicate tags.
| remote_src: true | ||
| become: true | ||
| when: hostvars[inventory_hostname].stackhpc_repos_enabled | ||
| tags: post |
Contributor
There was a problem hiding this comment.
The post tag is already applied to the entire play, so this tags definition is redundant and can be removed.
| - sources.list.d/ubuntu.sources | ||
| become: true | ||
| when: hostvars[inventory_hostname].stackhpc_repos_enabled | ||
| tags: post |
Contributor
There was a problem hiding this comment.
The post tag is already applied to the entire play, so this tags definition is redundant and can be removed.
jovial
commented
Feb 20, 2026
jovial
commented
Feb 20, 2026
priteau
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.