Merged
Conversation
We decided to keep 2024.1 at Docker Engine v28.
elelaysh
approved these changes
Feb 23, 2026
Contributor
elelaysh
left a comment
elelaysh
left a comment
There was a problem hiding this comment.
this will catch unwanted upgrade indeed.
Thanks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the maximum allowed Docker version for the StackHPC cloud tests. The change correctly aligns with the decision to use Docker Engine v28 for the 2024.1 release. I have provided one suggestion, which aligns with repository guidelines, to improve the maintainability of this configuration by moving the version variables to a more centralized location within the playbook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We decided to keep 2024.1 at Docker Engine v28.