Support skipping Rocky Linux version check#2201
Merged
Alex-Welsh merged 2 commits intostackhpc/2024.1from Mar 9, 2026
Merged
Conversation
This can be useful if the playbook has been interrupted before finishing, but the rocky-release package is already updated to 9.7. (cherry picked from commit 0640fd1)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a skip_rocky_96_version_check variable to bypass the initial OS version check in the Rocky Linux 9.7 upgrade playbook. This is useful for re-running an interrupted playbook. My review includes a suggestion to improve the robustness of this check by modifying it to explicitly allow either version 9.6 for initial runs or 9.7 for re-runs, preventing accidental runs on unsupported OS versions. This approach aligns with defining configuration variables with sensible defaults for override.
(cherry picked from commit 357c170)
Alex-Welsh
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be useful if the playbook has been interrupted before finishing, but the rocky-release package is already updated to 9.7.
(cherry picked from commit 0640fd1)