Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the repository mirror usernames and Ansible Vault passwords for the ci-aio and ci-builder environments, appending the 'yoga' release suffix. The review feedback suggests replacing the hardcoded release name in the usernames with the openstack_release variable to enhance maintainability and simplify future upgrades.
| # Use Ark's package repositories to install packages. | ||
| stackhpc_repo_mirror_url: "{{ stackhpc_release_pulp_url }}" | ||
| stackhpc_repo_mirror_username: "skc-ci-aio" | ||
| stackhpc_repo_mirror_username: "skc-ci-aio-yoga" |
There was a problem hiding this comment.
To improve maintainability and make it easier to adapt this configuration for future OpenStack releases, consider using the openstack_release variable to construct the username. This avoids hardcoding the release name. Ensure that the resulting username remains dedicated to this specific environment to maintain isolation as per our security guidelines.
stackhpc_repo_mirror_username: "skc-ci-aio-{{ openstack_release }}"References
- Use dedicated credentials and users for distinct environments to improve security and isolation, rather than sharing them.
| # Use Ark's package repositories to install packages. | ||
| stackhpc_repo_mirror_url: "{{ stackhpc_repo_mirror_auth_proxy_url if stackhpc_repo_mirror_auth_proxy_enabled | bool else stackhpc_release_pulp_url }}" | ||
| stackhpc_repo_mirror_username: "skc-ci-builder-reader" | ||
| stackhpc_repo_mirror_username: "skc-ci-builder-reader-yoga" |
There was a problem hiding this comment.
To improve maintainability and make it easier to adapt this configuration for future OpenStack releases, consider using the openstack_release variable to construct the username. This avoids hardcoding the release name. Ensure that the resulting username remains dedicated to this specific environment to maintain isolation as per our security guidelines.
stackhpc_repo_mirror_username: "skc-ci-builder-reader-{{ openstack_release }}"References
- Use dedicated credentials and users for distinct environments to improve security and isolation, rather than sharing them.
2 participants
No description provided.