Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the repository mirror usernames and vaulted passwords for the ci-aio and ci-builder environments, appending a release-specific suffix. The feedback suggests using the openstack_release variable instead of hardcoding 'zed' to improve maintainability and ensure better environment isolation.
| # Use Ark's package repositories to install packages. | ||
| stackhpc_repo_mirror_url: "{{ stackhpc_release_pulp_url }}" | ||
| stackhpc_repo_mirror_username: "skc-ci-aio" | ||
| stackhpc_repo_mirror_username: "skc-ci-aio-zed" |
There was a problem hiding this comment.
To improve maintainability and ensure environment isolation, consider using the openstack_release variable to construct the username instead of hardcoding 'zed'. This aligns with practices seen elsewhere in the configuration and supports the requirement to use dedicated credentials for distinct environments to improve security.
stackhpc_repo_mirror_username: "skc-ci-aio-{{ openstack_release }}"References
- Use dedicated credentials and users for distinct environments to improve security and isolation, rather than sharing them.
| # Use Ark's package repositories to install packages. | ||
| stackhpc_repo_mirror_url: "{{ stackhpc_repo_mirror_auth_proxy_url if stackhpc_repo_mirror_auth_proxy_enabled | bool else stackhpc_release_pulp_url }}" | ||
| stackhpc_repo_mirror_username: "skc-ci-builder-reader" | ||
| stackhpc_repo_mirror_username: "skc-ci-builder-reader-zed" |
There was a problem hiding this comment.
To improve maintainability and ensure environment isolation, consider using the openstack_release variable to construct the username instead of hardcoding 'zed'. This makes the configuration more dynamic and ensures that credentials remain dedicated to the specific environment and release, improving security and isolation.
stackhpc_repo_mirror_username: "skc-ci-builder-reader-{{ openstack_release }}"References
- Use dedicated credentials and users for distinct environments to improve security and isolation, rather than sharing them.
2 participants
No description provided.