Rotate CI passwords (antelope)#2239
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the repository mirror usernames and Ansible Vault passwords for the ci-aio and ci-builder environments to include the 'antelope' release suffix. The reviewer suggests using the openstack_release_codename variable instead of hardcoding the release name to improve maintainability and simplify future updates.
| # Use Ark's package repositories to install packages. | ||
| stackhpc_repo_mirror_url: "{{ stackhpc_release_pulp_url }}" | ||
| stackhpc_repo_mirror_username: "skc-ci-aio" | ||
| stackhpc_repo_mirror_username: "skc-ci-aio-antelope" |
There was a problem hiding this comment.
To improve maintainability and avoid hardcoding the release name, consider using the openstack_release_codename variable to construct this username. This will make it easier to update for future OpenStack releases. Ensure that the resulting username remains dedicated to this environment to maintain isolation as per security guidelines.
stackhpc_repo_mirror_username: "skc-ci-aio-{{ openstack_release_codename }}"References
- Use dedicated credentials and users for distinct environments to improve security and isolation, rather than sharing them.
| # Use Ark's package repositories to install packages. | ||
| stackhpc_repo_mirror_url: "{{ stackhpc_repo_mirror_auth_proxy_url if stackhpc_repo_mirror_auth_proxy_enabled | bool else stackhpc_release_pulp_url }}" | ||
| stackhpc_repo_mirror_username: "skc-ci-builder-reader" | ||
| stackhpc_repo_mirror_username: "skc-ci-builder-reader-antelope" |
There was a problem hiding this comment.
To improve maintainability and avoid hardcoding the release name, consider using the openstack_release_codename variable to construct this username. This will make it easier to update for future OpenStack releases. Ensure that the resulting username remains dedicated to this environment to maintain isolation as per security guidelines.
stackhpc_repo_mirror_username: "skc-ci-builder-reader-{{ openstack_release_codename }}"References
- Use dedicated credentials and users for distinct environments to improve security and isolation, rather than sharing them.
3 participants
No description provided.