Build Rocky Linux 10 container images#2252
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables Epoxy container image builds on Rocky Linux 10 by adding the required repository configurations, version variables, and image customizations. It also introduces Valkey support for Rocky 10 while maintaining Redis for older distributions. Feedback highlights critical issues where YAML block scalars incorrectly convert lists into strings, which would break Jinja2 loops during the build process. Additionally, the review identifies shell variable escaping and indentation errors in a manually generated repository file, and suggests a more robust method for accessing version-specific customizations.
owenjones
force-pushed
the
rl10/container-images
branch
from
c838aee to
ad3c5bd
Compare
owenjones
force-pushed
the
rl10/container-images
branch
from
ad3c5bd to
6823e3f
Compare
owenjones
force-pushed
the
rl10/container-images
branch
from
282db56 to
b0c4a0a
Compare
owenjones
force-pushed
the
rl10/container-images
branch
from
b0c4a0a to
00248f2
Compare
Changes: * Updated workflow to build Rocky 10 Kolla container images * Updated ci-builder environment to enable valkey image building on Rocky 10 (and enable redis image building on Rocky 9/Ubuntu Noble) * Updated ci-builder environment with pulp tags for Rocky 10 repositories * Added new OVN-LTS repository into pulp repository configuration * Added Rocky 10 repositories into Kolla configuration * Added new `stackhpc_enable_ovn_lts_repo` flag to Kolla configuration to inject OVN-LTS repository into apt sources * Updated Kolla build customisations to separate out Rocky 9 and 10 customisations, and added customisations for Rocky 10 * Added valkey images to pulp image list, and updated unbuildable images lists to reflect
|
Valkey images are buildable if specified in the workflow, but currently don't get fed into the list of default regexes even when |
1 participant
Changes:
stackhpc_enable_ovn_lts_repoflag to Kolla configuration to inject OVN-LTS repository file