Skip to content

Add Rocky Linux security repositories#2304

Open
priteau wants to merge 1 commit into
stackhpc/2025.1from
rocky-security
Open

Add Rocky Linux security repositories#2304
priteau wants to merge 1 commit into
stackhpc/2025.1from
rocky-security

Conversation

@priteau
Copy link
Copy Markdown
Member

@priteau priteau commented May 11, 2026

No description provided.

@priteau priteau self-assigned this May 11, 2026
@priteau priteau requested a review from a team as a code owner May 11, 2026 09:20
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds security repository configurations for Rocky Linux 9 and 10 across several Kayobe configuration files, including DNF, Pulp, and StackHPC settings. The feedback highlights a missing security repository definition for Rocky Linux 10 in the DNF configuration, which should be added for consistency with the Rocky 9 changes and the provided Pulp configuration.

Comment thread etc/kayobe/dnf.yml
Comment on lines +140 to +147
security:
baseurl: "{{ stackhpc_repo_rocky_9_security_url }}"
description: "Rocky Linux $releasever - Security"
file: rocky-security
gpgkey: "{{ rocky_9_gpg_key }}"
gpgcheck: yes
username: "{{ stackhpc_repo_mirror_username | default(omit, true) }}"
password: "{{ stackhpc_repo_mirror_password | default(omit, true) }}"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Rocky Linux 9 security repository is added here, but there is no corresponding addition for Rocky Linux 10, despite Rocky 10 security repositories being added to the Pulp configuration in this same pull request. If Rocky 10 is supported, it should also have its security repository defined in the DNF configuration.

@Alex-Welsh
Copy link
Copy Markdown
Member

 msg: 'Failed to download metadata for repo ''security'': Cannot download repomd.xml:  Cannot download repodata/repomd.xml: All mirrors were tried'

https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/25661511200/job/75324203229?pr=2304#step:25:418

Looks like an issue with the new repo

@Alex-Welsh
Copy link
Copy Markdown
Member

Cancelling upgrade jobs to save resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants