finished error detection when API rejects the attach request

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>

Author: nschad

pkg/csi/blockstorage/controllerserver.go

@@ -371,10 +371,9 @@ func (cs *controllerServer) ControllerPublishVolume(ctx context.Context, req *cs
 	_, err = cloud.AttachVolume(ctx, instanceID, volumeID)
 	if err != nil {
 		// Trigger's an immediate `NodeGetInfo` RPC call when MutableCSINodeAllocatableCount is enabled
-		// TODO: Finish Implementation of IsTooManyDevicesError
-		//if stackiterrors.IsTooManyDevicesError(err) {
-		//	return nil, status.Errorf(codes.ResourceExhausted, "[ControllerPublishVolume] Node can't accept any more volumes %v. All PCIe lanes are exhausted!", err)
-		//}
+		if stackiterrors.IsTooManyDevicesError(err) {
+			return nil, status.Errorf(codes.ResourceExhausted, "[ControllerPublishVolume] Node can't accept any more volumes %v. All PCIe lanes are exhausted!", err)
+		}
 		klog.Errorf("Failed to AttachVolume: %v", err)
 		return nil, status.Errorf(codes.Internal, "[ControllerPublishVolume] Attach Volume failed with error %v", err)
 	}

pkg/stackit/stackiterrors/errors.go

@@ -27,9 +27,9 @@ func IsTooManyDevicesError(err error) bool {
 		return false
 	}
 
-	// TODO: This is just a placeholder. Implement this correctly
-	return oAPIError.StatusCode == http.StatusInternalServerError &&
-		strings.Contains(oAPIError.ErrorMessage, "devices")
+	// TODO: Improve this if possible
+	return oAPIError.StatusCode == http.StatusForbidden &&
+		strings.Contains(oAPIError.ErrorMessage, "maximum allowed number of disk devices")
 }
 
 func IgnoreNotFound(err error) error {