Skip to content

add region in csi-blockstorage config#165

Open
aniruddha2000 wants to merge 3 commits into
mainfrom
cleanup-stackit-client
Open

add region in csi-blockstorage config#165
aniruddha2000 wants to merge 3 commits into
mainfrom
cleanup-stackit-client

Conversation

@aniruddha2000

@aniruddha2000 aniruddha2000 commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

This PR adds config to csi-blockstorage.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

@ske-prow

ske-prow Bot commented Jun 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign aniruddha2000 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 2, 2026
@nschad

nschad commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

/hold
needs to be rolled out together with the new CSI client

@ske-prow ske-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2026
nschad
nschad reviewed Jun 10, 2026
View reviewed changes
Comment thread ...plane/charts/stackit-blockstorage-csi-driver/templates/deployment-csi-driver-controller.yaml
{{- if .Values.stackitEndpoints.tokenUrl }}
- name: STACKIT_TOKEN_BASEURL
value: {{ .Values.stackitEndpoints.tokenUrl }}
{{- end }}

@nschad nschad Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh?

@aniruddha2000 aniruddha2000 Jun 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current split PR method uses old csi that takes region from env var and new ccm uses config method, next PR i will work on ccm and this will be removed

@nschad nschad Jun 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the {{ end}} and introduce a new {{ if }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nschad nschad nschad left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aniruddha2000 @nschad