Skip to content

🤖 Update gardener/gardener to v1.144.0#170

Open
ske-renovate-operator[bot] wants to merge 2 commits into
mainfrom
renovate/gardenergardener
Open

🤖 Update gardener/gardener to v1.144.0#170
ske-renovate-operator[bot] wants to merge 2 commits into
mainfrom
renovate/gardenergardener

Conversation

@ske-renovate-operator

@ske-renovate-operator ske-renovate-operator Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
github.com/gardener/gardener v1.143.1v1.144.0 age confidence
github.com/gardener/gardener/pkg/apis v1.143.1v1.144.0 age confidence

Release Notes

gardener/gardener (github.com/gardener/gardener)

v1.144.0

Compare Source

[github.com/gardener/gardener:v1.144.0]

⚠️ Breaking Changes

  • [OPERATOR] The UseUnifiedHTTPProxyPort feature gate has graduated to GA and cannot be disabled anymore. The feature gate can be removed from your component configuration. If you're using gardener-extension-acl, ensure that all shoots enabling the extension have been successfully reconciled with version v1.15.0 or higher before upgrading to this Gardener version that enables the feature gate unconditionally. by @​timebertt [#​14899]
  • [DEVELOPER] The third_party/mock/controller-runtime/client package is now dropped. You should migrate your usages of mock clients to fake client (sigs.k8s.io/controller-runtime/pkg/client/fake). by @​shafeeqes [#​14799]
  • [DEPENDENCY] The reusable CI scripts hack/.ci/component_descriptor and hack/.ci/prepare_release are now removed. They were previously used by Gardener extensions. After the migration from Concourse to GitHub Actions, these are now provided as reusable steps in the gardener/cc-utils repository. by @​ialidzhikov [#​14345]

✨ New Features

  • [OPERATOR] gardenadm init now supports exposing the self-hosted shoot API server via a SelfHostedShootExposure extension object when controlPlane.exposure.extension is configured. by @​cerealsnow [#​14781]
  • [OPERATOR] gardener-resource-manager now includes an istio-cluster-configuration controller which configures the envoy edge proxy best practices for upstream services configured for istio-ingressgateway. by @​oliver-goetz [#​14690]
  • [USER] The Shoot spec field spec.kubernetes.kubeAPIServer.encryptionConfig.provider.type is no longer immutable. by @​AleksandarSavchev [#​14720]
  • [USER] The Garden spec fields spec.virtualCluster.kubernetes.kubeAPIServer.encryptionConfig.provider.type and spec.virtualCluster.gardener.gardenerAPIServer.encryptionConfig.provider.type are no longer immutable. by @​AleksandarSavchev [#​14720]

🐛 Bug Fixes

  • [OPERATOR] A bug has been fixed where gardener-resource-manager would crash-loop after a hibernated shoot woke up with an expired authentication token. The bootstrap detection now evaluates the current time dynamically instead of using a value frozen at gardenlet startup. by @​shafeeqes [#​14937]
  • [OPERATOR] A bug was resolved that caused some Istio configuration to be applied to all istio-ingressgateway deployments when the runtime cluster is also a seed. A new label istio-role=seed|garden is now used to distinguish the two ingressgateways. by @​maboehm [#​14869]
  • [OPERATOR] A bug has been fixed where Garden resources would start encryption key rotation on creation. by @​AleksandarSavchev [#​14801]

🏃 Others

  • [OPERATOR] Add label app: victoria-logs to all resources in the VictoriaLogs setup + add label app: opentelemetry-collector to all resources in the OpenTelemetry Collector setup. by @​iypetrov [#​14704]
  • [OPERATOR] IstioTLSTermination feature gate has been promoted to beta. by @​oliver-goetz [#​14923]
  • [OPERATOR] The custom json unmarshalling logic for tokenExpirationDuration in GardenletConfiguration has been removed. by @​oliver-goetz [#​14921]
  • [OPERATOR] The gardener-node-agent is now able to deal with version v4 of containerd's configuration file /etc/containerd/config.toml (introduced with containerd 2.3). CRI plugin paths in v4 are identical to v3; only server-level fields moved into plugin blocks. The plugin path translation that maps v2-compliant prefixes to their v3 equivalents is now applied for all config file versions >= 3. by @​Vincinator [#​14856]
  • [OPERATOR] Removed v1alpha1 perses CRD migration code from the perses-operator component. by @​rickardsjp [#​14914]
  • [USER] The gardener-apiserver now rejects attempts to change the spec.seedName of the Shoot unless it is done via the binding subresource. Previously, these invalid updates were silently ignored. by @​shafeeqes [#​14919]
  • [USER] The sshd-ensurer service is changed to use a loop instead of restart every 15 seconds to prevent spamming journalctl with noisy logs. by @​AleksandarSavchev [#​14832]
  • [DEVELOPER] Logging components now remain available until worker termination is complete during the hibernation flow. by @​gagan16k [#​14916]
  • [DEVELOPER] e2e upgrade tests have been enabled again. by @​oliver-goetz [#​14900]
  • [DEPENDENCY] The following dependencies have been updated:
  • [DEPENDENCY] The following dependencies have been updated:
  • [DEPENDENCY] The following dependencies have been updated:
  • [DEPENDENCY] The following dependencies have been updated:
  • [DEPENDENCY] The following dependencies have been updated:
  • [DEPENDENCY] The following dependencies have been updated:
  • [DEPENDENCY] The following dependencies have been updated:

application/spdx+json

  • admission-controller-spdx-ref: europe-docker.pkg.dev/gardener-project/releases/gardener/admission-controller@sha256:1fbe63f6348adfdea254d93d510778c9b74573d7019818af966b81b9ba22bc2b
  • admission-controller-spdx-ref: europe-docker.pkg.dev/gardener-project/releases/gardener/admission-controller@sha256:f1f910f43c00806b618fa9ae82ce7e3e7433a89f848ab68120caca8dca12d3fd
  • apiserver-spdx-ref: europe-docker.pkg.dev/gardener-project/releases/gardener/apiserver@sha256:8865e277dc1a978c5c84b0e46f9e38faf4dabae5ae7e94f496c744b108eab149
  • apiserver-spdx-ref: europe-docker.pkg.dev/gardener-project/releases/gardener/apiserver@sha256:d1cc2af9960f2d0c6d4d3d064a6feb870c1d5010f5eb6f26fad6f7189ec69e2a
  • controller-manager-spdx-ref: europe-docker.pkg.dev/gardener-project/releases/gardener/controller-manager@sha256:875880749d25ab4a4c9af5c54be9c8510b3b44219102c84adfec9b8210d52851
  • controller-manager-spdx-ref: europe-docker.pkg.dev/gardener-project/releases/gardener/controller-manager@sha256:9059b2463d90209a969f0d63d5cae9961e9135f24667ebac12a77e77c54a449d
  • gardenadm-spdx-ref: europe-docker.pkg.dev/gardener-project/releases/gardener/gardenadm@sha256:100cd21c29aaa2376a1186c9ceba1391ea72d11b1ad14e6b68eefdbbc158be31
  • gardenadm-spdx-ref: europe-docker.pkg.dev/gardener-project/releases/gardener/gardenadm@sha256:bfd3e320ccc21094a8a831a9e989df98917298cd5fb69fb2d7f102f1e67754c3
  • gardenlet-spdx-ref: europe-docker.pkg.dev/gardener-project/releases/gardener/gardenlet@sha256:34b3fe550bf2b18fd97f977f0c1a4dfcf69b01dfd39f6412eabde030780a5cbe
  • gardenlet-spdx-ref: europe-docker.pkg.dev/gardener-project/releases/gardener/gardenlet@sha256:bdc3c3d91ed301f5db37d2934e1a1f0c90fc2aa24c8925046d0561e0f12333ea
  • node-agent-spdx-ref: europe-docker.pkg.dev/gardener-project/releases/gardener/node-agent@sha256:7d6e4149bb128079a5e72e9362c2b1cc2e76c9f2fa1b963764a6fa5215f68383
  • node-agent-spdx-ref: europe-docker.pkg.dev/gardener-project/releases/gardener/node-agent@sha256:b588d444d6c11673b44a6ecae9909958c371c1a17c1c3f30ee0684b0beb68847
  • operator-spdx-ref: europe-docker.pkg.dev/gardener-project/releases/gardener/operator@sha256:42e6f1d31a5802ee9f21094c49b1777e9df8827891e50d6c30b565cef722725c
  • operator-spdx-ref: europe-docker.pkg.dev/gardener-project/releases/gardener/operator@sha256:c1893a86b2c920022fed1d17f0f85da10084399b130d27811eb176706cdff7cd
  • resource-manager-spdx-ref: europe-docker.pkg.dev/gardener-project/releases/gardener/resource-manager@sha256:0757a50cb759bf8c2388cc1848078de8410c1f3b7ea19bbbeb8825df71bd7b87
  • resource-manager-spdx-ref: europe-docker.pkg.dev/gardener-project/releases/gardener/resource-manager@sha256:8f0c8885215cd657543188cd29badc9714eb23f3932d1b87544f03d0d0d103ad
  • scheduler-spdx-ref: europe-docker.pkg.dev/gardener-project/releases/gardener/scheduler@sha256:b1cbbaaefcba3657735ff668d9f01acb80f9fb383b0bbe5239a210a21f9c8876
  • scheduler-spdx-ref: europe-docker.pkg.dev/gardener-project/releases/gardener/scheduler@sha256:f6c5654bd6fed68c304128b663ca42f548809fb23adccc30a2d70d00bcaa14c7

Helm Charts

  • gardenlet: europe-docker.pkg.dev/gardener-project/releases/charts/gardener/gardenlet:v1.144.0
  • operator: europe-docker.pkg.dev/gardener-project/releases/charts/gardener/operator:v1.144.0
  • resource-manager: europe-docker.pkg.dev/gardener-project/releases/charts/gardener/resource-manager:v1.144.0

Container (OCI) Images

  • admission-controller: europe-docker.pkg.dev/gardener-project/releases/gardener/admission-controller:v1.144.0
  • apiserver: europe-docker.pkg.dev/gardener-project/releases/gardener/apiserver:v1.144.0
  • controller-manager: europe-docker.pkg.dev/gardener-project/releases/gardener/controller-manager:v1.144.0
  • gardenadm: europe-docker.pkg.dev/gardener-project/releases/gardener/gardenadm:v1.144.0
  • gardenlet: europe-docker.pkg.dev/gardener-project/releases/gardener/gardenlet:v1.144.0
  • node-agent: europe-docker.pkg.dev/gardener-project/releases/gardener/node-agent:v1.144.0
  • operator: europe-docker.pkg.dev/gardener-project/releases/gardener/operator:v1.144.0
  • resource-manager: europe-docker.pkg.dev/gardener-project/releases/gardener/resource-manager:v1.144.0
  • scheduler: europe-docker.pkg.dev/gardener-project/releases/gardener/scheduler:v1.144.0

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate.

@ske-renovate-operator ske-renovate-operator Bot added the kind/upgrade Upgrading components or dependencies (e.g., by renovate) label Jun 5, 2026
@ske-renovate-operator ske-renovate-operator Bot requested a review from a team June 5, 2026 08:58
@ske-renovate-operator

Copy link
Copy Markdown
Contributor Author

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go.sum
Command failed: go get -t ./...
go: downloading github.com/gardener/gardener v1.144.0
go: downloading sigs.k8s.io/controller-runtime v0.23.3
go: downloading github.com/gardener/etcd-druid/api v0.36.3
go: downloading github.com/gardener/gardener/pkg/apis v1.144.0
go: downloading github.com/gardener/machine-controller-manager v0.61.3
go: downloading k8s.io/apimachinery v0.35.5
go: downloading github.com/spf13/cobra v1.10.2
go: downloading github.com/go-logr/logr v1.4.3
go: downloading k8s.io/api v0.35.5
go: downloading k8s.io/autoscaler/vertical-pod-autoscaler v1.6.0
go: downloading k8s.io/client-go v0.35.5
go: downloading k8s.io/component-base v0.35.5
go: downloading github.com/gardener/gardener-extension-os-coreos v1.29.0
go: downloading golang.org/x/mod v0.36.0
go: downloading k8s.io/utils v0.0.0-20260507154919-ff6756f316d2
go: downloading github.com/onsi/ginkgo/v2 v2.29.0
go: downloading github.com/onsi/gomega v1.41.0
go: downloading github.com/Masterminds/semver/v3 v3.5.0
go: downloading github.com/google/uuid v1.6.0
go: downloading github.com/gardener/gardener-extension-networking-calico v1.58.0
go: downloading github.com/stackitcloud/stackit-sdk-go/services/iaas v1.12.2
go: downloading go.uber.org/mock v0.6.0
go: downloading github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.91.0
go: downloading github.com/spf13/pflag v1.0.10
go: downloading github.com/gophercloud/gophercloud/v2 v2.12.0
go: downloading k8s.io/apiextensions-apiserver v0.35.5
go: downloading go.uber.org/atomic v1.11.0
go: downloading github.com/google/go-cmp v0.7.0
go: downloading github.com/stackitcloud/stackit-sdk-go/services/loadbalancer v1.14.0
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/stackitcloud/stackit-sdk-go/core v0.26.0
go: downloading github.com/stackitcloud/stackit-sdk-go/services/dns v0.21.0
go: downloading github.com/gophercloud/utils/v2 v2.0.0-20260424064311-2eeed4ceb3e9
go: downloading github.com/coreos/go-systemd/v22 v22.7.0
go: downloading k8s.io/kubelet v0.35.5
go: downloading github.com/pelletier/go-toml/v2 v2.3.1
go: downloading go.uber.org/zap v1.28.0
go: downloading github.com/VictoriaMetrics/operator/api v0.66.1
go: downloading github.com/fluent/fluent-operator/v3 v3.7.0
go: downloading github.com/hashicorp/go-multierror v1.1.1
go: downloading github.com/kubernetes-csi/external-snapshotter/client/v4 v4.2.0
go: downloading github.com/perses/perses-operator v0.4.0
go: downloading istio.io/client-go v1.29.2
go: downloading k8s.io/kube-aggregator v0.35.5
go: downloading k8s.io/metrics v0.35.5
go: downloading github.com/stackitcloud/stackit-sdk-go/services/authorization v0.15.2
go: downloading github.com/stackitcloud/stackit-sdk-go/services/resourcemanager v0.24.0
go: downloading github.com/stackitcloud/stackit-sdk-go/services/serviceaccount v0.20.0
go: downloading sigs.k8s.io/yaml v1.6.0
go: downloading github.com/inconshreveable/mousetrap v1.1.0
go: downloading k8s.io/klog/v2 v2.140.0
go: downloading github.com/evanphx/json-patch/v5 v5.9.11
go: downloading github.com/elliotchance/orderedmap/v3 v3.1.0
go: downloading golang.org/x/crypto v0.52.0
go: downloading go.yaml.in/yaml/v4 v4.0.0-rc.2
go: downloading k8s.io/pod-security-admission v0.35.5
go: downloading sigs.k8s.io/randfill v1.0.0
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading k8s.io/kube-openapi v0.0.0-20260317180543-43fb72c5454a
go: downloading sigs.k8s.io/structured-merge-diff/v6 v6.3.2
go: downloading sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730
go: downloading github.com/andybalholm/brotli v1.2.1
go: downloading github.com/spf13/afero v1.15.0
go: downloading gopkg.in/evanphx/json-patch.v4 v4.13.0
go: downloading github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822
go: downloading golang.org/x/net v0.54.0
go: downloading golang.org/x/term v0.43.0
go: downloading github.com/mitchellh/hashstructure/v2 v2.0.2
go: downloading github.com/fatih/color v1.19.0
go: downloading github.com/prometheus/client_golang v1.23.3-0.20260602051030-3537b20ac86b
go: downloading github.com/go-logr/zapr v1.3.0
go: downloading github.com/gofrs/uuid/v5 v5.4.0
go: downloading gopkg.in/yaml.v3 v3.0.1
go: downloading go.uber.org/multierr v1.11.0
go: downloading github.com/Masterminds/sprig/v3 v3.3.0
go: downloading helm.sh/helm/v4 v4.1.4
go: downloading gomodules.xyz/jsonpatch/v2 v2.5.0
go: downloading github.com/VictoriaMetrics/VictoriaMetrics v1.131.0
go: downloading github.com/prometheus/alertmanager v0.29.0
go: downloading gopkg.in/yaml.v2 v2.4.0
go: downloading sigs.k8s.io/gateway-api v1.5.0
go: downloading github.com/goccy/go-yaml v1.19.2
go: downloading go.opentelemetry.io/contrib/otelconf v0.23.0
go: downloading github.com/hashicorp/errwrap v1.1.0
go: downloading github.com/brunoga/deep v1.3.1
go: downloading github.com/perses/perses v0.53.1
go: downloading istio.io/api v1.29.3
go: downloading github.com/gorilla/websocket v1.5.4-0.20250319132907-e064f32e3674
go: downloading go.yaml.in/yaml/v2 v2.4.4
go: downloading github.com/go-jose/go-jose/v4 v4.1.4
go: downloading github.com/json-iterator/go v1.1.13-0.20220915233716-71ac16282d12
go: downloading golang.org/x/text v0.37.0
go: downloading golang.org/x/time v0.15.0
go: downloading go.yaml.in/yaml/v3 v3.0.4
go: downloading golang.org/x/sys v0.45.0
go: downloading github.com/google/gnostic-models v0.7.1
go: downloading google.golang.org/protobuf v1.36.11
go: downloading github.com/fxamacker/cbor/v2 v2.9.0
go: downloading golang.org/x/oauth2 v0.36.0
go: downloading github.com/gardener/cert-management v0.23.0
go: downloading github.com/prometheus/common v0.68.0
go: downloading github.com/google/btree v1.1.3
go: downloading golang.org/x/sync v0.20.0
go: downloading github.com/mattn/go-colorable v0.1.14
go: downloading github.com/mattn/go-isatty v0.0.22
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/cespare/xxhash/v2 v2.3.0
go: downloading github.com/prometheus/client_model v0.6.2
go: downloading github.com/prometheus/procfs v0.20.1
go: downloading github.com/golang-jwt/jwt/v5 v5.3.1
go: downloading k8s.io/apiserver v0.35.5
go: downloading dario.cat/mergo v1.0.2
go: downloading github.com/Masterminds/goutils v1.1.1
go: downloading github.com/huandu/xstrings v1.5.0
go: downloading github.com/mitchellh/copystructure v1.2.0
go: downloading github.com/shopspring/decimal v1.4.0
go: downloading github.com/spf13/cast v1.10.0
go: downloading github.com/santhosh-tekuri/jsonschema/v6 v6.0.2
go: downloading github.com/cyphar/filepath-securejoin v0.6.1
go: downloading github.com/BurntSushi/toml v1.6.0
go: downloading github.com/gobwas/glob v0.2.3
go: downloading github.com/fsnotify/fsnotify v1.9.0
go: downloading github.com/prometheus/sigv4 v0.3.0
go: downloading github.com/prometheus/otlptranslator v1.0.0
go: downloading go.opentelemetry.io/otel v1.43.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc v0.19.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp v0.19.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.43.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp v1.43.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.43.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.43.0
go: downloading go.opentelemetry.io/otel/exporters/prometheus v0.65.0
go: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.43.0
go: downloading go.opentelemetry.io/otel/exporters/stdout/stdoutlog v0.19.0
go: downloading go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v1.43.0
go: downloading go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.43.0
go: downloading go.opentelemetry.io/otel/log v0.19.0
go: downloading go.opentelemetry.io/otel/metric v1.43.0
go: downloading go.opentelemetry.io/otel/sdk v1.43.0
go: downloading go.opentelemetry.io/otel/sdk/log v0.19.0
go: downloading go.opentelemetry.io/otel/sdk/metric v1.43.0
go: downloading google.golang.org/grpc v1.80.0
go: downloading go.opentelemetry.io/otel/trace v1.43.0
go: downloading github.com/PaesslerAG/gval v1.2.4
go: downloading github.com/PaesslerAG/jsonpath v0.1.2-0.20240726212847-3a740cf7976f
go: downloading github.com/google/cel-go v0.27.0
go: downloading github.com/perses/common v0.30.2
go: downloading github.com/sirupsen/logrus v1.9.4
go: downloading github.com/VictoriaMetrics/metrics v1.40.2
go: downloading github.com/valyala/quicktemplate v1.8.0
go: downloading github.com/bmatcuk/doublestar/v4 v4.10.0
go: downloading github.com/VictoriaMetrics/VictoriaLogs v1.36.2-0.20251008164716-21c0fb3de84d
go: downloading github.com/VictoriaMetrics/metricsql v0.84.8
go: downloading github.com/moby/spdystream v0.5.1
go: downloading github.com/golang/protobuf v1.5.4
go: downloading google.golang.org/genproto/googleapis/api v0.0.0-20260406210006-6f92a3bedf2d
go: downloading github.com/go-openapi/errors v0.22.7
go: downloading github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2
go: downloading github.com/go-openapi/jsonreference v0.21.5
go: downloading github.com/go-openapi/swag v0.25.4
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/modern-go/reflect2 v1.0.3-0.20250322232337-35a7c28c31ee
go: downloading github.com/go-task/slim-sprig/v3 v3.0.0
go: downloading golang.org/x/tools v0.45.0
go: downloading github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc
go: downloading github.com/x448/float16 v0.8.4
go: downloading github.com/blang/semver/v4 v4.0.0
go: downloading github.com/mitchellh/reflectwalk v1.0.2
go: downloading github.com/mwitkow/go-conntrack v0.0.0-20190716064945-2f068394615f
go: downloading github.com/aws/aws-sdk-go-v2 v1.41.7
go: downloading github.com/aws/aws-sdk-go-v2/config v1.32.17
go: downloading github.com/aws/aws-sdk-go-v2/credentials v1.19.16
go: downloading github.com/aws/aws-sdk-go-v2/service/sts v1.42.1
go: downloading go.opentelemetry.io/proto/otlp v1.10.0
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20260427160629-7cedc36a6bc4
go: downloading github.com/nexucis/lamenv v0.5.2
go: downloading github.com/zitadel/oidc/v3 v3.45.4
go: downloading github.com/valyala/fastjson v1.6.4
go: downloading github.com/VictoriaMetrics/easyproto v0.1.4
go: downloading github.com/valyala/bytebufferpool v1.0.0
go: downloading github.com/valyala/fastrand v1.1.0
go: downloading github.com/valyala/histogram v1.2.0
go: downloading github.com/valyala/fasttemplate v1.2.2
go: downloading cel.dev/expr v0.25.1
go: downloading github.com/mxk/go-flowrate v0.0.0-20140419014527-cca7078d478f
go: downloading github.com/go-openapi/jsonpointer v0.22.5
go: downloading github.com/go-openapi/swag/cmdutils v0.25.4
go: downloading github.com/go-openapi/swag/conv v0.26.0
go: downloading github.com/go-openapi/swag/fileutils v0.26.0
go: downloading github.com/go-openapi/swag/jsonname v0.25.5
go: downloading github.com/go-openapi/swag/jsonutils v0.26.0
go: downloading github.com/go-openapi/swag/loading v0.25.5
go: downloading github.com/go-openapi/swag/mangling v0.25.5
go: downloading github.com/go-openapi/swag/netutils v0.25.4
go: downloading github.com/go-openapi/swag/stringutils v0.26.0
go: downloading github.com/go-openapi/swag/typeutils v0.26.0
go: downloading github.com/go-openapi/swag/yamlutils v0.25.5
go: downloading github.com/google/pprof v0.0.0-20260402051712-545e8a4df936
go: downloading k8s.io/cluster-bootstrap v0.35.5
go: downloading github.com/jpillora/backoff v1.0.0
go: downloading github.com/aws/smithy-go v1.25.1
go: downloading github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.18.23
go: downloading github.com/aws/aws-sdk-go-v2/service/signin v1.0.11
go: downloading github.com/aws/aws-sdk-go-v2/service/sso v1.30.17
go: downloading github.com/aws/aws-sdk-go-v2/service/ssooidc v1.35.21
go: downloading github.com/go-logr/stdr v1.2.2
go: downloading go.opentelemetry.io/auto/sdk v1.2.1
go: downloading github.com/cenkalti/backoff/v5 v5.0.3
go: downloading github.com/aws/aws-sdk-go-v2/internal/configsources v1.4.23
go: downloading github.com/aws/aws-sdk-go-v2/internal/v4a v1.4.24
go: downloading github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.13.9
go: downloading github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.13.23
go: downloading github.com/grpc-ecosystem/grpc-gateway/v2 v2.28.0
go: downloading github.com/muhlemmer/gu v0.3.1
go: downloading github.com/zitadel/schema v1.3.2
go: downloading github.com/klauspost/compress v1.18.6
go: downloading github.com/antlr4-go/antlr/v4 v4.13.1
go: downloading github.com/emicklei/go-restful/v3 v3.13.0
go: downloading k8s.io/component-helpers v0.35.5
go: downloading github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.7.23
go: downloading github.com/valyala/gozstd v1.24.0
go: downloading golang.org/x/exp v0.0.0-20260410095643-746e56fc9e2f
go: downloading github.com/labstack/echo/v4 v4.15.1
go: downloading github.com/labstack/gommon v0.4.2
go: github.com/stackitcloud/gardener-extension-provider-stackit/v2/pkg/controller/controlplane tested by
	github.com/stackitcloud/gardener-extension-provider-stackit/v2/pkg/controller/controlplane.test imports
	github.com/gardener/gardener/third_party/mock/controller-runtime/client: cannot find module providing package github.com/gardener/gardener/third_party/mock/controller-runtime/client

@ske-prow

ske-prow Bot commented Jun 5, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dergeberl for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 5, 2026
@ske-prow ske-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 9, 2026
@breuerfelix breuerfelix requested a review from dergeberl June 9, 2026 07:22

@dergeberl dergeberl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working but maybe not the intended way. We also cloud use the sigs.k8s.io/controller-runtime/pkg/client/fake instead of mock our own. This is maybe more effort in changing the tests but also a lot more simple as we dont need to init the mocks for each object/call. WDYT?

/hold

@ske-prow ske-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2026
@ske-renovate-operator

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@breuerfelix

Copy link
Copy Markdown
Member

It is working but maybe not the intended way. We also cloud use the sigs.k8s.io/controller-runtime/pkg/client/fake instead of mock our own. This is maybe more effort in changing the tests but also a lot more simple as we dont need to init the mocks for each object/call. WDYT?

/hold

I had a look at the fake client and also generated the implementation in order to see how it would look like compared to the current mock implementation.
To me, using fake clients, does not improve readability or is "nicer" than mocks. It is just a different approach and it is nice that we do not need generated code. It was just about the same amount of code.
However since we are currently using mocks all over the place, it was a little odd to have fakes + mocks mixed, thats why i decided against the fake client since the mock approach aligns better with our repository.

We should answer the following question: Do we in general prefer fakes over mocks and want to convert our mocks into fake clients in the future aswell?
If yes: we should use this opportunity and use the fake client here as suggested by gardener.
If no: we should not mix mocks and fakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/upgrade Upgrading components or dependencies (e.g., by renovate) size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants