forked from gardener/gardener
-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathreconciler_test.go
More file actions
406 lines (386 loc) · 13.9 KB
/
reconciler_test.go
File metadata and controls
406 lines (386 loc) · 13.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
// SPDX-FileCopyrightText: SAP SE or an SAP affiliate company and Gardener contributors
//
// SPDX-License-Identifier: Apache-2.0
package worker_test
import (
"context"
"encoding/json"
"errors"
"reflect"
"time"
"github.com/go-logr/logr"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
"go.uber.org/mock/gomock"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/types"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/client/fake"
"sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
extensionscontroller "github.com/gardener/gardener/extensions/pkg/controller"
"github.com/gardener/gardener/extensions/pkg/controller/worker"
extensionsmockworker "github.com/gardener/gardener/extensions/pkg/controller/worker/mock"
gardencorev1beta1 "github.com/gardener/gardener/pkg/apis/core/v1beta1"
v1beta1constants "github.com/gardener/gardener/pkg/apis/core/v1beta1/constants"
extensionsv1alpha1 "github.com/gardener/gardener/pkg/apis/extensions/v1alpha1"
"github.com/gardener/gardener/pkg/client/kubernetes"
mockclient "github.com/gardener/gardener/third_party/mock/controller-runtime/client"
mockmanager "github.com/gardener/gardener/third_party/mock/controller-runtime/manager"
)
var _ = Describe("Worker Reconcile", func() {
type fields struct {
logger logr.Logger
actuator func(ctrl *gomock.Controller) worker.Actuator
ctx context.Context
client client.Client
}
type args struct {
request reconcile.Request
}
type test struct {
fields fields
args args
want reconcile.Result
wantErr bool
}
// Immutable through the function calls
arguments := args{
request: reconcile.Request{
NamespacedName: types.NamespacedName{
Name: "workerTestReconcile",
Namespace: "test",
},
},
}
var (
ctrl *gomock.Controller
ctx context.Context
logger logr.Logger
mgr *mockmanager.MockManager
)
BeforeEach(func() {
ctrl = gomock.NewController(GinkgoT())
ctx = context.TODO()
logger = log.Log.WithName("Reconcile-Test-Controller")
// Create fake manager
mgr = mockmanager.NewMockManager(ctrl)
})
AfterEach(func() {
ctrl.Finish()
})
var (
newMockActuator = func(op string, err error) func(ctrl *gomock.Controller) worker.Actuator {
return func(ctrl *gomock.Controller) worker.Actuator {
actuator := extensionsmockworker.NewMockActuator(ctrl)
switch op {
case "reconcile":
actuator.EXPECT().Reconcile(ctx, gomock.AssignableToTypeOf(logr.Logger{}), gomock.AssignableToTypeOf(&extensionsv1alpha1.Worker{}), gomock.AssignableToTypeOf(&extensionscontroller.Cluster{})).Return(err)
case "delete":
actuator.EXPECT().Delete(ctx, gomock.AssignableToTypeOf(logr.Logger{}), gomock.AssignableToTypeOf(&extensionsv1alpha1.Worker{}), gomock.AssignableToTypeOf(&extensionscontroller.Cluster{})).Return(err)
case "restore":
actuator.EXPECT().Restore(ctx, gomock.AssignableToTypeOf(logr.Logger{}), gomock.AssignableToTypeOf(&extensionsv1alpha1.Worker{}), gomock.AssignableToTypeOf(&extensionscontroller.Cluster{})).Return(err)
case "migrate":
actuator.EXPECT().Migrate(ctx, gomock.AssignableToTypeOf(logr.Logger{}), gomock.AssignableToTypeOf(&extensionsv1alpha1.Worker{}), gomock.AssignableToTypeOf(&extensionscontroller.Cluster{})).Return(err)
}
return actuator
}
}
)
DescribeTable("Reconcile function", func(t *test) {
apiReader := mockclient.NewMockReader(ctrl)
mgr.EXPECT().GetClient().Return(t.fields.client).AnyTimes()
mgr.EXPECT().GetAPIReader().Return(apiReader).AnyTimes()
reconciler := worker.NewReconciler(mgr, t.fields.actuator(ctrl))
got, err := reconciler.Reconcile(ctx, t.args.request)
Expect(err != nil).To(Equal(t.wantErr))
Expect(reflect.DeepEqual(got, t.want)).To(BeTrue())
},
Entry("test reconcile", &test{
fields: fields{
logger: logger,
actuator: newMockActuator("reconcile", nil),
ctx: context.TODO(),
client: fake.NewClientBuilder().WithScheme(kubernetes.SeedScheme).WithObjects(
addOperationAnnotationToWorker(
getWorker(),
v1beta1constants.GardenerOperationReconcile),
getCluster()).WithStatusSubresource(&extensionsv1alpha1.Worker{}).Build(),
},
args: arguments,
want: reconcile.Result{},
wantErr: false,
}),
Entry("test after successful migrate", &test{
fields: fields{
logger: logger,
actuator: newMockActuator("", nil),
ctx: context.TODO(),
client: fake.NewClientBuilder().WithScheme(kubernetes.SeedScheme).WithObjects(
addFinalizerToWorker(
addDeletionTimestampToWorker(
addOperationAnnotationToWorker(
addLastOperationToWorker(
getWorker(),
gardencorev1beta1.LastOperationTypeMigrate,
gardencorev1beta1.LastOperationStateSucceeded,
"Migrate worker"),
v1beta1constants.GardenerOperationReconcile)),
worker.FinalizerName),
getCluster()).WithStatusSubresource(&extensionsv1alpha1.Worker{}).Build(),
},
args: arguments,
want: reconcile.Result{},
wantErr: false,
}),
Entry("test migrate when operationAnnotation Migrate occurs", &test{
fields: fields{
logger: logger,
actuator: newMockActuator("migrate", nil),
ctx: context.TODO(),
client: fake.NewClientBuilder().WithScheme(kubernetes.SeedScheme).WithObjects(
addOperationAnnotationToWorker(
getWorker(),
v1beta1constants.GardenerOperationMigrate),
getCluster()).WithStatusSubresource(&extensionsv1alpha1.Worker{}).Build(),
},
args: arguments,
want: reconcile.Result{},
wantErr: false,
}),
Entry("test error during migrate when operationAnnotation Migrate occurs", &test{
fields: fields{
logger: logger,
actuator: newMockActuator("migrate", errors.New("test")),
ctx: context.TODO(),
client: fake.NewClientBuilder().WithScheme(kubernetes.SeedScheme).WithObjects(
addOperationAnnotationToWorker(
getWorker(),
v1beta1constants.GardenerOperationMigrate),
getCluster()).WithStatusSubresource(&extensionsv1alpha1.Worker{}).Build(),
},
args: arguments,
want: reconcile.Result{},
wantErr: true,
}),
Entry("test Migrate after unsuccessful Migrate", &test{
fields: fields{
logger: logger,
actuator: newMockActuator("migrate", nil),
ctx: context.TODO(),
client: fake.NewClientBuilder().WithScheme(kubernetes.SeedScheme).WithObjects(
addLastOperationToWorker(
getWorker(),
gardencorev1beta1.LastOperationTypeMigrate,
gardencorev1beta1.LastOperationStateFailed,
"Migrate worker"),
getCluster()).WithStatusSubresource(&extensionsv1alpha1.Worker{}).Build(),
},
args: arguments,
want: reconcile.Result{},
wantErr: false,
}),
Entry("test error during Migrate after unsuccessful Migrate", &test{
fields: fields{
logger: logger,
actuator: newMockActuator("migrate", errors.New("test")),
ctx: context.TODO(),
client: fake.NewClientBuilder().WithScheme(kubernetes.SeedScheme).WithObjects(
addLastOperationToWorker(
getWorker(),
gardencorev1beta1.LastOperationTypeMigrate,
gardencorev1beta1.LastOperationStateFailed,
"Migrate worker"),
getCluster()).WithStatusSubresource(&extensionsv1alpha1.Worker{}).Build(),
},
args: arguments,
want: reconcile.Result{},
wantErr: true,
}),
Entry("test Delete Worker", &test{
fields: fields{
logger: logger,
actuator: newMockActuator("delete", nil),
ctx: context.TODO(),
client: fake.NewClientBuilder().WithScheme(kubernetes.SeedScheme).WithObjects(
addFinalizerToWorker(addDeletionTimestampToWorker(getWorker()), worker.FinalizerName),
getCluster()).WithStatusSubresource(&extensionsv1alpha1.Worker{}).Build(),
},
args: arguments,
want: reconcile.Result{},
wantErr: false,
}),
Entry("test error when Delete Worker", &test{
fields: fields{
logger: logger,
actuator: newMockActuator("delete", errors.New("test")),
ctx: context.TODO(),
client: fake.NewClientBuilder().WithScheme(kubernetes.SeedScheme).WithObjects(
addFinalizerToWorker(addDeletionTimestampToWorker(getWorker()), worker.FinalizerName),
getCluster()).WithStatusSubresource(&extensionsv1alpha1.Worker{}).Build(),
},
args: arguments,
want: reconcile.Result{},
wantErr: true,
}),
Entry("test restore when operationAnnotation Restore occurs", &test{
fields: fields{
logger: logger,
actuator: newMockActuator("restore", nil),
ctx: context.TODO(),
client: fake.NewClientBuilder().WithScheme(kubernetes.SeedScheme).WithObjects(
addOperationAnnotationToWorker(
getWorker(),
v1beta1constants.GardenerOperationRestore),
getCluster()).WithStatusSubresource(&extensionsv1alpha1.Worker{}).Build(),
},
args: arguments,
want: reconcile.Result{},
wantErr: false,
}),
Entry("test error restore when operationAnnotation Restore occurs", &test{
fields: fields{
logger: logger,
actuator: newMockActuator("restore", errors.New("test")),
ctx: context.TODO(),
client: fake.NewClientBuilder().WithScheme(kubernetes.SeedScheme).WithObjects(
addOperationAnnotationToWorker(
getWorker(),
v1beta1constants.GardenerOperationRestore),
getCluster()).WithStatusSubresource(&extensionsv1alpha1.Worker{}).Build(),
},
args: arguments,
want: reconcile.Result{},
wantErr: true,
}),
Entry("test reconcile after failed reconciliation", &test{
fields: fields{
logger: logger,
actuator: newMockActuator("reconcile", nil),
ctx: context.TODO(),
client: fake.NewClientBuilder().WithScheme(kubernetes.SeedScheme).WithObjects(
addLastOperationToWorker(
getWorker(),
gardencorev1beta1.LastOperationTypeReconcile,
gardencorev1beta1.LastOperationStateFailed,
"Reconcile worker"),
getCluster()).WithStatusSubresource(&extensionsv1alpha1.Worker{}).Build(),
},
args: arguments,
want: reconcile.Result{},
wantErr: false,
}),
Entry("test reconcile after successful restoration reconciliation", &test{
fields: fields{
logger: logger,
actuator: newMockActuator("reconcile", nil),
ctx: context.TODO(),
client: fake.NewClientBuilder().WithScheme(kubernetes.SeedScheme).WithObjects(
addLastOperationToWorker(
getWorker(),
gardencorev1beta1.LastOperationTypeReconcile,
gardencorev1beta1.LastOperationStateProcessing,
"Process worker reconciliation"),
getCluster()).WithStatusSubresource(&extensionsv1alpha1.Worker{}).Build(),
},
args: arguments,
want: reconcile.Result{},
wantErr: false,
}),
Entry("test error while reconciliation after failed reconciliation", &test{
fields: fields{
logger: logger,
actuator: newMockActuator("reconcile", errors.New("test")),
ctx: context.TODO(),
client: fake.NewClientBuilder().WithScheme(kubernetes.SeedScheme).WithObjects(
addLastOperationToWorker(
getWorker(),
gardencorev1beta1.LastOperationTypeReconcile,
gardencorev1beta1.LastOperationStateFailed,
"Reconcile worker"),
getCluster()).WithStatusSubresource(&extensionsv1alpha1.Worker{}).Build(),
},
args: arguments,
want: reconcile.Result{},
wantErr: true,
}),
Entry("test error while reconciliation after successful restoration reconciliation", &test{
fields: fields{
logger: logger,
actuator: newMockActuator("reconcile", errors.New("test")),
ctx: context.TODO(),
client: fake.NewClientBuilder().WithScheme(kubernetes.SeedScheme).WithObjects(
addLastOperationToWorker(
getWorker(),
gardencorev1beta1.LastOperationTypeReconcile,
gardencorev1beta1.LastOperationStateProcessing,
"Process worker reconciliation"),
getCluster()).WithStatusSubresource(&extensionsv1alpha1.Worker{}).Build(),
},
args: arguments,
want: reconcile.Result{},
wantErr: true,
}),
)
})
func getWorker() *extensionsv1alpha1.Worker {
return &extensionsv1alpha1.Worker{
TypeMeta: metav1.TypeMeta{
Kind: "Worker",
APIVersion: "extensions.gardener.cloud/v1alpha1",
},
ObjectMeta: metav1.ObjectMeta{
Name: "workerTestReconcile",
Namespace: "test",
ResourceVersion: "42",
},
Spec: extensionsv1alpha1.WorkerSpec{},
}
}
func addOperationAnnotationToWorker(worker *extensionsv1alpha1.Worker, annotation string) *extensionsv1alpha1.Worker {
worker.Annotations = make(map[string]string)
worker.Annotations[v1beta1constants.GardenerOperation] = annotation
return worker
}
func addLastOperationToWorker(worker *extensionsv1alpha1.Worker, lastOperationType gardencorev1beta1.LastOperationType, lastOperationState gardencorev1beta1.LastOperationState, description string) *extensionsv1alpha1.Worker {
worker.Status.LastOperation = extensionscontroller.LastOperation(lastOperationType, lastOperationState, 1, description)
return worker
}
func addDeletionTimestampToWorker(worker *extensionsv1alpha1.Worker) *extensionsv1alpha1.Worker {
worker.DeletionTimestamp = &metav1.Time{Time: time.Now()}
return worker
}
func addFinalizerToWorker(worker *extensionsv1alpha1.Worker, finalizer string) *extensionsv1alpha1.Worker {
worker.Finalizers = append(worker.Finalizers, finalizer)
return worker
}
func getCluster() *extensionsv1alpha1.Cluster {
return &extensionsv1alpha1.Cluster{
TypeMeta: metav1.TypeMeta{
Kind: "Cluster",
APIVersion: "extensions.gardener.cloud/v1alpha1",
},
ObjectMeta: metav1.ObjectMeta{
Name: "test",
},
Spec: extensionsv1alpha1.ClusterSpec{
Shoot: runtime.RawExtension{
Raw: encode(&gardencorev1beta1.Shoot{
TypeMeta: metav1.TypeMeta{
Kind: "Shoot",
APIVersion: "core.gardener.cloud/v1beta1",
},
ObjectMeta: metav1.ObjectMeta{
Name: "test",
},
}),
},
},
}
}
func encode(obj runtime.Object) []byte {
bytes, err := json.Marshal(obj)
Expect(err).NotTo(HaveOccurred())
return bytes
}