forked from gardener/gardener
-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathreconciler_test.go
More file actions
422 lines (389 loc) · 16.8 KB
/
reconciler_test.go
File metadata and controls
422 lines (389 loc) · 16.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
// SPDX-FileCopyrightText: SAP SE or an SAP affiliate company and Gardener contributors
//
// SPDX-License-Identifier: Apache-2.0
package hibernation
import (
"context"
"time"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
. "github.com/onsi/gomega/gstruct"
"github.com/robfig/cron"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/tools/events"
"k8s.io/component-base/version"
testclock "k8s.io/utils/clock/testing"
"k8s.io/utils/ptr"
"sigs.k8s.io/controller-runtime/pkg/client"
fakeclient "sigs.k8s.io/controller-runtime/pkg/client/fake"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
controllermanagerconfigv1alpha1 "github.com/gardener/gardener/pkg/apis/config/controllermanager/v1alpha1"
gardencorev1beta1 "github.com/gardener/gardener/pkg/apis/core/v1beta1"
"github.com/gardener/gardener/pkg/client/kubernetes"
)
var _ = Describe("Shoot Hibernation", func() {
type testEntry struct {
timeNow func() time.Time
triggerDeadlineDuration time.Duration
shootSettings func(shoot *gardencorev1beta1.Shoot)
triggerHibernationOrWakeup bool
expectedRequeueDurationFunc func(now time.Time) time.Duration
expectedHibernationEnabled bool
}
var (
everyDayAt2 = "00 02 * * 1,2,3,4,5,6,0"
everyDayAt7 = "00 07 * * 1,2,3,4,5,6,0"
everyWeekDayAt8 = "00 08 * * 1,2,3,4,5"
everyWeekDayAt19 = "00 19 * * 1,2,3,4,5"
locationEUBerlin = "Europe/Berlin"
locationEUSofia = "Europe/Sofia"
weekDayAt2 = "2022-04-12T02:00:00Z"
weekDayAt0 = "2022-04-12T00:00:00Z"
weekDayAt7 = "2022-04-12T07:00:00Z"
weekDayAt19 = "2022-04-12T19:00:00Z"
noDeadLine = -1234 * time.Second
shortDeadline = 10 * time.Second
longDeadline = 10 * time.Hour
mustParseStandard = func(standardSpec string) cron.Schedule {
sched, err := cron.ParseStandard(standardSpec)
Expect(err).NotTo(HaveOccurred())
return sched
}
mustLoadLocation = func(locationName string) time.Location {
location, err := time.LoadLocation(locationName)
Expect(err).NotTo(HaveOccurred())
return *location
}
requeueAfterBasedOnSchedule = func(schedule, location string) func(now time.Time) time.Duration {
return func(now time.Time) time.Duration {
parsedSchedule := mustParseStandard(schedule)
loc := mustLoadLocation(location)
return parsedSchedule.Next(now.In(&loc)).Add(nextScheduleDelta).Sub(now)
}
}
mustParseRFC3339Time = func(t string) time.Time {
parsedTime, err := time.Parse(time.RFC3339, t)
Expect(err).NotTo(HaveOccurred())
return parsedTime
}
timeWithOffset = func(t string, offset time.Duration) func() time.Time {
return func() time.Time {
parsedTime := mustParseRFC3339Time(t)
return parsedTime.Add(offset)
}
}
)
Context("parsedHibernationSchedule", func() {
Describe("#next", func() {
It("should correctly return the next scheduling time from the parsed schedule", func() {
now := mustParseRFC3339Time(weekDayAt2)
expected := mustParseRFC3339Time(weekDayAt0).Add(24 * time.Hour)
parsedSchedule := parsedHibernationSchedule{
location: mustLoadLocation(locationEUBerlin),
schedule: mustParseStandard(everyDayAt2),
}
Expect(parsedSchedule.next(now)).To(Equal(expected))
})
})
Describe("#previous", func() {
It("should correctly return the previous scheduling time from the parsed schedule if it is within the specified range", func() {
now := mustParseRFC3339Time(weekDayAt2)
from := now.Add(-2 * 24 * time.Hour)
expected := mustParseRFC3339Time(weekDayAt0)
parsedSchedule := parsedHibernationSchedule{
location: mustLoadLocation(locationEUBerlin),
schedule: mustParseStandard(everyDayAt2),
}
prev := parsedSchedule.previous(from, now)
Expect(prev).NotTo(BeNil())
Expect(*prev).To(Equal(expected))
})
It("should return nil if previous scheduling time was not in specified range", func() {
now := mustParseRFC3339Time(weekDayAt2)
from := now.Add(-1 * time.Hour)
parsedSchedule := parsedHibernationSchedule{
location: mustLoadLocation(locationEUBerlin),
schedule: mustParseStandard(everyDayAt2),
}
prev := parsedSchedule.previous(from, now)
Expect(prev).To(BeNil())
})
})
})
Context("Shoot hibernation reconciliation", func() {
Describe("#Reconcile", func() {
var (
ctx context.Context
c client.Client
now time.Time
fakeClock *testclock.FakeClock
shoot *gardencorev1beta1.Shoot
)
BeforeEach(func() {
ctx = context.TODO()
shoot = &gardencorev1beta1.Shoot{
ObjectMeta: metav1.ObjectMeta{
Name: "bar",
Namespace: "garden-foo",
},
Spec: gardencorev1beta1.ShootSpec{
Hibernation: &gardencorev1beta1.Hibernation{},
},
Status: gardencorev1beta1.ShootStatus{},
}
c = fakeclient.NewClientBuilder().WithScheme(kubernetes.GardenScheme).WithStatusSubresource(&gardencorev1beta1.Shoot{}).Build()
})
DescribeTable("should properly enable or disable hibernation and requeue the shoot", func(t testEntry) {
By("Set current time")
timeNow := now
if t.timeNow != nil {
timeNow = t.timeNow()
}
fakeClock = testclock.NewFakeClock(timeNow)
if t.shootSettings != nil {
By("Configure shoot")
t.shootSettings(shoot)
}
By("Create shoot")
Expect(c.Create(ctx, shoot)).To(Succeed())
By("Configure hibernation reconciler")
config := controllermanagerconfigv1alpha1.ShootHibernationControllerConfiguration{}
if t.triggerDeadlineDuration != noDeadLine {
config.TriggerDeadlineDuration = &metav1.Duration{Duration: t.triggerDeadlineDuration}
}
reconciler := &Reconciler{
Client: c,
Config: config,
Recorder: events.NewFakeRecorder(1),
Clock: fakeClock,
}
By("Reconcile shoot resource")
var requeueAfter time.Duration
if t.expectedRequeueDurationFunc != nil {
requeueAfter = t.expectedRequeueDurationFunc(timeNow)
}
result, err := reconciler.Reconcile(ctx,
reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(shoot),
},
)
Expect(err).ToNot(HaveOccurred())
Expect(result).To(Equal(reconcile.Result{RequeueAfter: requeueAfter}))
reconciledShoot := &gardencorev1beta1.Shoot{}
Expect(c.Get(ctx, client.ObjectKeyFromObject(shoot), reconciledShoot)).To(Succeed())
if t.triggerHibernationOrWakeup {
Expect(reconciledShoot.Spec.Hibernation.Enabled).To(PointTo(Equal(t.expectedHibernationEnabled)))
Expect(reconciledShoot.Status.LastHibernationTriggerTime.Time.UTC()).To(Equal(timeNow))
} else {
Expect(reconciledShoot.Spec.Hibernation.Enabled).To(BeNil())
}
},
Entry("when there are no hibernation schedules nothing should be done", testEntry{
timeNow: timeWithOffset(weekDayAt2, 0),
shootSettings: func(shoot *gardencorev1beta1.Shoot) {
shoot.CreationTimestamp = metav1.Time{Time: timeWithOffset(weekDayAt2, 0)()}
},
}),
Entry("when hibernation schedule is incorrect nothing should be done and shoot must not be requeued", testEntry{
timeNow: timeWithOffset(weekDayAt2, 0),
shootSettings: func(shoot *gardencorev1beta1.Shoot) {
shoot.CreationTimestamp = metav1.Time{Time: timeWithOffset(weekDayAt2, 0)()}
shoot.Spec.Hibernation.Schedules = []gardencorev1beta1.HibernationSchedule{{Start: ptr.To("")}}
},
}),
Entry("when shoot has never been hibernated and reconciliation is executed 30 seconds before wakeup schedule", testEntry{
timeNow: timeWithOffset(weekDayAt2, -30*time.Second),
shootSettings: func(shoot *gardencorev1beta1.Shoot) {
shoot.CreationTimestamp = metav1.Time{Time: timeWithOffset(weekDayAt2, -1*24*time.Hour)()}
shoot.Spec.Hibernation.Schedules = []gardencorev1beta1.HibernationSchedule{{
Start: &everyDayAt7,
End: &everyDayAt2,
}}
},
triggerDeadlineDuration: noDeadLine,
triggerHibernationOrWakeup: true,
expectedHibernationEnabled: true,
expectedRequeueDurationFunc: requeueAfterBasedOnSchedule(everyDayAt2, "UTC"),
}),
Entry("when shoot has never been hibernated and reconciliation is executed just before hibernation schedule", testEntry{
timeNow: timeWithOffset(weekDayAt7, -1*time.Second),
shootSettings: func(shoot *gardencorev1beta1.Shoot) {
shoot.CreationTimestamp = metav1.Time{Time: timeWithOffset(weekDayAt7, -1*24*time.Hour)()}
shoot.Spec.Hibernation.Schedules = []gardencorev1beta1.HibernationSchedule{{
Start: &everyDayAt7,
End: &everyDayAt2,
}}
},
triggerDeadlineDuration: noDeadLine,
triggerHibernationOrWakeup: true,
expectedHibernationEnabled: false,
expectedRequeueDurationFunc: requeueAfterBasedOnSchedule(everyDayAt7, "UTC"),
}),
Entry("when shoot has never hibernated and reconciliation is executed just after hibernation start schedule", testEntry{
timeNow: timeWithOffset(weekDayAt7, 1*time.Second),
shootSettings: func(shoot *gardencorev1beta1.Shoot) {
shoot.CreationTimestamp = metav1.Time{Time: timeWithOffset(weekDayAt7, -1*24*time.Hour)()}
shoot.Spec.Hibernation.Schedules = []gardencorev1beta1.HibernationSchedule{{
Start: &everyDayAt7,
End: &everyDayAt2,
}}
},
triggerDeadlineDuration: noDeadLine,
triggerHibernationOrWakeup: true,
expectedHibernationEnabled: true,
expectedRequeueDurationFunc: requeueAfterBasedOnSchedule(everyDayAt2, "UTC"),
}),
Entry("when shoot has never been hibernated and reconciliation is executed exactly at hibernation start schedule", testEntry{
timeNow: timeWithOffset(weekDayAt7, 0),
shootSettings: func(shoot *gardencorev1beta1.Shoot) {
shoot.CreationTimestamp = metav1.Time{Time: timeWithOffset(weekDayAt7, -30*time.Second)()}
shoot.Spec.Hibernation.Schedules = []gardencorev1beta1.HibernationSchedule{{
Start: &everyDayAt7,
End: &everyDayAt2,
}}
},
triggerDeadlineDuration: noDeadLine,
triggerHibernationOrWakeup: true,
expectedHibernationEnabled: true,
expectedRequeueDurationFunc: requeueAfterBasedOnSchedule(everyDayAt2, "UTC"),
}),
Entry("when shoot has just been created", testEntry{
timeNow: timeWithOffset(weekDayAt19, 1*time.Second),
shootSettings: func(shoot *gardencorev1beta1.Shoot) {
shoot.CreationTimestamp = metav1.Time{Time: timeWithOffset(weekDayAt19, 0)()}
shoot.Spec.Hibernation.Schedules = []gardencorev1beta1.HibernationSchedule{{
Start: &everyDayAt7,
End: &everyDayAt2,
}}
},
triggerDeadlineDuration: noDeadLine,
expectedRequeueDurationFunc: requeueAfterBasedOnSchedule(everyDayAt2, "UTC"),
}),
Entry("when shoot has never been hibernated and has multiple hibernation schedules and reconciliation is executed just after hibernation", testEntry{
timeNow: timeWithOffset(weekDayAt7, 1*time.Second),
shootSettings: func(shoot *gardencorev1beta1.Shoot) {
shoot.CreationTimestamp = metav1.Time{Time: timeWithOffset(weekDayAt7, -1*24*time.Hour)()}
shoot.Spec.Hibernation.Schedules = []gardencorev1beta1.HibernationSchedule{
{
Start: &everyDayAt7,
End: &everyDayAt2,
Location: &locationEUBerlin,
},
{
Start: &everyWeekDayAt8,
End: &everyWeekDayAt19,
Location: &locationEUSofia,
},
{
Start: &everyDayAt2,
End: &everyDayAt7,
},
}
},
triggerDeadlineDuration: noDeadLine,
triggerHibernationOrWakeup: true,
expectedHibernationEnabled: false,
expectedRequeueDurationFunc: requeueAfterBasedOnSchedule(everyWeekDayAt19, locationEUSofia),
}),
Entry("when shoot has been hibernated or woken up previously and reconciliation is executed exactly after hibernation start time", testEntry{
timeNow: timeWithOffset(weekDayAt7, 1*time.Second),
shootSettings: func(shoot *gardencorev1beta1.Shoot) {
shoot.CreationTimestamp = metav1.Time{Time: timeWithOffset(weekDayAt7, -24*time.Hour)()}
shoot.Spec.Hibernation.Schedules = []gardencorev1beta1.HibernationSchedule{{
Start: &everyDayAt7,
End: &everyDayAt2,
}}
shoot.Status.LastHibernationTriggerTime = &metav1.Time{Time: timeWithOffset(weekDayAt2, 0)()}
},
triggerDeadlineDuration: noDeadLine,
triggerHibernationOrWakeup: true,
expectedHibernationEnabled: true,
expectedRequeueDurationFunc: requeueAfterBasedOnSchedule(everyDayAt2, "UTC"),
}),
Entry("when shoot has been hibernated or woken up previously and reconciliation is executed before hibernation start time", testEntry{
timeNow: timeWithOffset(weekDayAt7, -1*time.Second),
shootSettings: func(shoot *gardencorev1beta1.Shoot) {
shoot.CreationTimestamp = metav1.Time{Time: timeWithOffset(weekDayAt7, -24*time.Hour)()}
shoot.Spec.Hibernation.Schedules = []gardencorev1beta1.HibernationSchedule{{
Start: &everyDayAt7,
End: &everyDayAt2,
}}
shoot.Status.LastHibernationTriggerTime = &metav1.Time{Time: timeWithOffset(weekDayAt2, 0)()}
},
triggerDeadlineDuration: noDeadLine,
expectedRequeueDurationFunc: requeueAfterBasedOnSchedule(everyDayAt7, "UTC"),
}),
Entry("when shoot was not hibernated and current reconciliation is within the hibernation deadline", testEntry{
timeNow: timeWithOffset(weekDayAt7, 1*time.Second),
shootSettings: func(shoot *gardencorev1beta1.Shoot) {
shoot.CreationTimestamp = metav1.Time{Time: timeWithOffset(weekDayAt7, -24*time.Hour)()}
shoot.Spec.Hibernation.Schedules = []gardencorev1beta1.HibernationSchedule{{
Start: &everyDayAt7,
End: &everyDayAt2,
}}
},
triggerDeadlineDuration: longDeadline,
triggerHibernationOrWakeup: true,
expectedHibernationEnabled: true,
expectedRequeueDurationFunc: requeueAfterBasedOnSchedule(everyDayAt2, "UTC"),
}),
Entry("when shoot was previously hibernated and current reconciliation is within the hibernation deadline", testEntry{
timeNow: timeWithOffset(weekDayAt7, 1*time.Second),
shootSettings: func(shoot *gardencorev1beta1.Shoot) {
shoot.CreationTimestamp = metav1.Time{Time: timeWithOffset(weekDayAt7, -24*time.Hour)()}
shoot.Spec.Hibernation.Schedules = []gardencorev1beta1.HibernationSchedule{{
Start: &everyDayAt7,
End: &everyDayAt2,
}}
shoot.Status.LastHibernationTriggerTime = &metav1.Time{Time: timeWithOffset(weekDayAt2, 0)()}
},
triggerDeadlineDuration: longDeadline,
triggerHibernationOrWakeup: true,
expectedHibernationEnabled: true,
expectedRequeueDurationFunc: requeueAfterBasedOnSchedule(everyDayAt2, "UTC"),
}),
Entry("when shoot was not previously hibernated and current reconciliation is outside hibernation deadline", testEntry{
timeNow: timeWithOffset(weekDayAt7, shortDeadline+1*time.Second),
shootSettings: func(shoot *gardencorev1beta1.Shoot) {
shoot.CreationTimestamp = metav1.Time{Time: timeWithOffset(weekDayAt7, -24*time.Hour)()}
shoot.Spec.Hibernation.Schedules = []gardencorev1beta1.HibernationSchedule{{
Start: &everyDayAt7,
End: &everyDayAt2,
}}
},
triggerDeadlineDuration: shortDeadline,
expectedRequeueDurationFunc: requeueAfterBasedOnSchedule(everyDayAt2, "UTC"),
}),
Entry("when shoot was previously hibernated and current reconciliation is outside hibernation deadline", testEntry{
timeNow: timeWithOffset(weekDayAt7, shortDeadline+1*time.Second),
shootSettings: func(shoot *gardencorev1beta1.Shoot) {
shoot.CreationTimestamp = metav1.Time{Time: timeWithOffset(weekDayAt7, -24*time.Hour)()}
shoot.Spec.Hibernation.Schedules = []gardencorev1beta1.HibernationSchedule{{
Start: &everyDayAt7,
End: &everyDayAt2,
}}
shoot.Status.LastHibernationTriggerTime = &metav1.Time{Time: timeWithOffset(weekDayAt2, 0)()}
},
triggerDeadlineDuration: shortDeadline,
expectedRequeueDurationFunc: requeueAfterBasedOnSchedule(everyDayAt2, "UTC"),
}),
Entry("when shoot is in failed state", testEntry{
timeNow: timeWithOffset(weekDayAt7, shortDeadline+1*time.Second),
shootSettings: func(shoot *gardencorev1beta1.Shoot) {
shoot.CreationTimestamp = metav1.Time{Time: timeWithOffset(weekDayAt7, 1*time.Second)()}
shoot.Spec.Hibernation.Schedules = []gardencorev1beta1.HibernationSchedule{
{
Start: &everyDayAt7,
End: &everyDayAt2,
},
}
shoot.Status.LastOperation = &gardencorev1beta1.LastOperation{State: gardencorev1beta1.LastOperationStateFailed}
shoot.Status.Gardener.Version = version.Get().GitVersion
},
triggerDeadlineDuration: shortDeadline,
expectedRequeueDurationFunc: requeueAfterBasedOnSchedule(everyDayAt2, "UTC"),
}),
)
})
})
})