set DeleteOnTermination per default to true (#122)

Signed-off-by: Felix Breuer <f.breuer94@gmail.com>

Author: breuerfelix

go.mod

@@ -13,6 +13,7 @@ require (
 	k8s.io/apimachinery v0.35.1
 	k8s.io/component-base v0.35.1
 	k8s.io/klog/v2 v2.130.1
+	k8s.io/utils v0.0.0-20251002143259-bc988d571ff4
 )
 
 require (
@@ -68,7 +69,6 @@ require (
 	k8s.io/client-go v0.35.1 // indirect
 	k8s.io/cluster-bootstrap v0.31.0 // indirect
 	k8s.io/kube-openapi v0.0.0-20250910181357-589584f1c912 // indirect
-	k8s.io/utils v0.0.0-20251002143259-bc988d571ff4 // indirect
 	sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730 // indirect
 	sigs.k8s.io/randfill v1.0.0 // indirect
 	sigs.k8s.io/structured-merge-diff/v6 v6.3.0 // indirect

pkg/provider/create.go

@@ -15,6 +15,7 @@ import (
 	"github.com/stackitcloud/machine-controller-manager-provider-stackit/pkg/provider/apis/validation"
 	"k8s.io/apimachinery/pkg/util/wait"
 	"k8s.io/klog/v2"
+	"k8s.io/utils/ptr"
 )
 
 // CreateMachine handles a machine creation request by creating a STACKIT server
@@ -155,7 +156,10 @@ func (p *Provider) createServerRequest(req *driver.CreateMachineRequest, provide
 	// Add boot volume configuration if specified
 	if providerSpec.BootVolume != nil {
 		createReq.BootVolume = &client.BootVolumeRequest{
-			DeleteOnTermination: providerSpec.BootVolume.DeleteOnTermination,
+			// DeleteOnTermination defaults to false in the IaaS API
+			// unless explicitly disabled, bootVolumes should always be cleaned up automatically
+			// otherwise this produces many orphaned volumes since node rolls happen frequently in k8s
+			DeleteOnTermination: ptr.To(ptr.Deref(providerSpec.BootVolume.DeleteOnTermination, true)),
 			PerformanceClass:    providerSpec.BootVolume.PerformanceClass,
 			Size:                providerSpec.BootVolume.Size,
 		}