Skip to content

Commit d8fe336

Browse files
authored
chore: update dependency pin (rag-core-lib) to document-extractor service (#231)
This pull request adds support for updating the `rag-core-lib` dependency pin in the `document-extractor` service's `pyproject.toml` and introduces a corresponding test to ensure this functionality works as expected. Dependency management improvements: * Updated the `SERVICE_PINS` mapping in `bump_pyproject_deps.py` to include `rag-core-lib` for the `document-extractor` service, allowing its version pin to be updated alongside `extractor-api-lib`. Testing enhancements: * Added a new test, `test_bump_updates_service_pins`, to verify that both `extractor-api-lib` and `rag-core-lib` version pins are correctly updated in the service's `pyproject.toml` when `bump_service_pins=True` is used.
1 parent 79f4dfc commit d8fe336

File tree

2 files changed

+39
-0
lines changed

2 files changed

+39
-0
lines changed

tools/bump_pyproject_deps.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
},
4747
ROOT / 'services' / 'document-extractor' / 'pyproject.toml': {
4848
'tool.poetry.group.prod.dependencies.extractor-api-lib': '=={v}',
49+
'tool.poetry.group.prod.dependencies.rag-core-lib': '=={v}',
4950
},
5051
}
5152

tools/tests/test_bump_pyproject_deps.py

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,3 +94,41 @@ def test_bump_updates_internal_lib_dependency_pins(tmp_path: Path, monkeypatch)
9494
assert rag_core_api_doc["tool"]["poetry"]["dependencies"]["rag-core-lib"] == "==4.1.0"
9595
assert admin_api_doc["tool"]["poetry"]["dependencies"]["rag-core-lib"] == "==4.1.0"
9696
assert extractor_api_doc["tool"]["poetry"]["dependencies"]["rag-core-lib"] == "==4.1.0"
97+
98+
99+
def test_bump_updates_service_pins(tmp_path: Path, monkeypatch) -> None:
100+
service_pyproject = tmp_path / "document-extractor.toml"
101+
service_pyproject.write_text(
102+
"\n".join(
103+
[
104+
"[tool.poetry]",
105+
"name = \"extractor-server\"",
106+
"version = \"0.1.0\"",
107+
"",
108+
"[tool.poetry.group.prod.dependencies]",
109+
"extractor-api-lib = \"==4.0.0\"",
110+
"rag-core-lib = \"==4.0.0\"",
111+
"",
112+
]
113+
)
114+
+ "\n"
115+
)
116+
117+
monkeypatch.setattr(
118+
bump_pyproject_deps,
119+
"SERVICE_PINS",
120+
{
121+
service_pyproject: {
122+
"tool.poetry.group.prod.dependencies.extractor-api-lib": "=={v}",
123+
"tool.poetry.group.prod.dependencies.rag-core-lib": "=={v}",
124+
}
125+
},
126+
)
127+
128+
bump_pyproject_deps.bump("4.1.0", bump_libs=False, bump_service_pins=True)
129+
130+
doc = tomlkit.parse(service_pyproject.read_text())
131+
deps = doc["tool"]["poetry"]["group"]["prod"]["dependencies"]
132+
133+
assert deps["extractor-api-lib"] == "==4.1.0"
134+
assert deps["rag-core-lib"] == "==4.1.0"

0 commit comments

Comments
 (0)