feat: make mcptool description configurable#55
Merged
Conversation
Member
Author
|
addresses #54 |
- Updated configmap.yaml to include new environment variables for chat tools. - Expanded README.md with detailed Helm chart configuration for MCP server. - Added Jinja2 and MarkupSafe dependencies to poetry.lock for template rendering. - Modified mcp_settings.py to improve parameter descriptions and default values. - Refactored docstring_system.py to streamline docstring rendering and parameter extraction. - Improved test coverage in docstring_system_test.py for new configurations and behaviors.
MelvinKl
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the MCP server, including the addition of an extensible docstring system, restructuring of file paths, and enhancements to configuration and testing setups. These changes aim to improve maintainability, scalability, and developer experience.
Enhancements to MCP Server Functionality
DocstringTemplateSystem) that uses Jinja2 templates to dynamically generate method docstrings based on configuration. This includes theextensible_docstringdecorator andsetup_extensible_docstringsutility for seamless integration. (services/mcp-server/src/docstring_system.py,services/mcp-server/src/rag_mcp_server.py) [1] [2] [3]MCPSettingsclass to include detailed configuration options forchat_simpleandchat_with_historymethods, such as descriptions, parameter details, return types, and examples. These settings are used by the new docstring system. (services/mcp-server/src/settings/mcp_settings.py) [1] [2]Restructuring and Path Updates
.vscode/settings.jsonandconftest.pyto align with the new directory structure underservices/. This includes addingmcp-server/srcand updating imports for backend services. (.vscode/settings.json,conftest.py) [1] [2]Infrastructure and Configuration Updates
configmap.yaml,values.yaml) to support additional metadata for the MCP server, such as host, descriptions, and examples for chat tools. These changes enable better customization and documentation. (infrastructure/rag/templates/backend/configmap.yaml,infrastructure/rag/values.yaml) [1] [2]Testing and Development Environment Improvements
pyproject.tomlinmcp-server, including markers for test categorization (e.g.,unit,integration) and additional pytest options. (services/mcp-server/pyproject.toml)testpathsinlibs/rag-core-api/pyproject.tomlto use a list format for consistency with other configurations. (libs/rag-core-api/pyproject.toml)Dependency Updates
jinja2as a new dependency inservices/mcp-server/pyproject.tomlto support the docstring templating system. (services/mcp-server/pyproject.toml)