fix: remove unused max_pages parameter from confluence loader parameters#86
Merged
fix: remove unused max_pages parameter from confluence loader parameters#86
Conversation
youssefcamao
reviewed
Sep 2, 2025
Collaborator
youssefcamao
left a comment
youssefcamao
left a comment
There was a problem hiding this comment.
you don't want to log any errors or warning when there is an invalid max_pages?
youssefcamao
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces an improvement to the handling of the
max_pagesparameter in the Confluence extractor. The update ensures that the parameter is only included if it is properly set and of the correct type, which helps prevent potential issues when passing parameters to theConfluenceLoader.Parameter handling improvements:
extractors/confluence_extractor.py, the code now removes themax_pagesparameter fromconfluence_loader_parametersif it is missing or is a string, ensuring only valid integer values are passed to the loader.This PR fixes following issue:
#85