-
Notifications
You must be signed in to change notification settings - Fork 37
Expand file tree
/
Copy pathcreate_test.go
More file actions
365 lines (348 loc) · 10.8 KB
/
create_test.go
File metadata and controls
365 lines (348 loc) · 10.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
package create
import (
"context"
"testing"
"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"github.com/google/uuid"
"github.com/spf13/cobra"
intake "github.com/stackitcloud/stackit-sdk-go/services/intake/v1betaapi"
"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
"github.com/stackitcloud/stackit-cli/internal/pkg/print"
"github.com/stackitcloud/stackit-cli/internal/pkg/testutils"
"github.com/stackitcloud/stackit-cli/internal/pkg/types"
"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
)
// Define a unique key for the context to avoid collisions
type testCtxKey struct{}
const (
testRegion = "eu01"
testDisplayName = "testintake"
testDescription = "This is a test intake"
testLabelsString = "env=test,team=dev"
testCatalogURI = "http://dremio.example.com"
testCatalogWarehouse = "my-warehouse"
testCatalogNamespace = "test-namespace"
testCatalogTableName = "test-table"
testCatalogPartitioning = "manual"
testCatalogPartitionByFlag = "year,month"
testCatalogAuthType = "dremio"
testDremioTokenEndpoint = "https://auth.dremio.cloud/oauth/token" //nolint:gosec // false url
testDremioToken = "dremio-secret-token"
)
var (
// testCtx dummy context for testing purposes
testCtx = context.WithValue(context.Background(), testCtxKey{}, "foo")
// testClient mock API client
testClient = &intake.APIClient{
DefaultAPI: &intake.DefaultAPIService{},
}
testProjectId = uuid.NewString()
testRunnerId = uuid.NewString()
testLabels = map[string]string{"env": "test", "team": "dev"}
testCatalogPartitionBy = []string{"year", "month"}
)
// fixtureFlagValues generates a map of flag values for tests
func fixtureFlagValues(mods ...func(flagValues map[string]string)) map[string]string {
flagValues := map[string]string{
globalflags.ProjectIdFlag: testProjectId,
globalflags.RegionFlag: testRegion,
displayNameFlag: testDisplayName,
runnerIdFlag: testRunnerId,
descriptionFlag: testDescription,
labelsFlag: testLabelsString,
catalogURIFlag: testCatalogURI,
catalogWarehouseFlag: testCatalogWarehouse,
catalogNamespaceFlag: testCatalogNamespace,
catalogTableNameFlag: testCatalogTableName,
catalogPartitionByFlag: testCatalogPartitionByFlag,
catalogPartitioningFlag: testCatalogPartitioning,
catalogAuthTypeFlag: testCatalogAuthType,
dremioTokenEndpointFlag: testDremioTokenEndpoint,
dremioPatFlag: testDremioToken,
}
for _, mod := range mods {
mod(flagValues)
}
return flagValues
}
// fixtureInputModel generates an input model for tests
func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
model := &inputModel{
GlobalFlagModel: &globalflags.GlobalFlagModel{
ProjectId: testProjectId,
Region: testRegion,
Verbosity: globalflags.VerbosityDefault,
},
DisplayName: utils.Ptr(testDisplayName),
RunnerId: utils.Ptr(testRunnerId),
Description: utils.Ptr(testDescription),
Labels: utils.Ptr(testLabels),
CatalogURI: utils.Ptr(testCatalogURI),
CatalogWarehouse: utils.Ptr(testCatalogWarehouse),
CatalogNamespace: utils.Ptr(testCatalogNamespace),
CatalogTableName: utils.Ptr(testCatalogTableName),
CatalogPartitionBy: utils.Ptr(testCatalogPartitionBy),
CatalogPartitioning: utils.Ptr(testCatalogPartitioning),
CatalogAuthType: utils.Ptr(testCatalogAuthType),
DremioTokenEndpoint: utils.Ptr(testDremioTokenEndpoint),
DremioToken: utils.Ptr(testDremioToken),
}
for _, mod := range mods {
mod(model)
}
return model
}
// fixtureCreatePayload generates a CreateIntakePayload for tests
func fixtureCreatePayload(mods ...func(payload *intake.CreateIntakePayload)) intake.CreateIntakePayload {
authType := intake.CatalogAuthType(testCatalogAuthType)
testPartitioningType := intake.PartitioningType(testCatalogPartitioning)
payload := intake.CreateIntakePayload{
DisplayName: testDisplayName,
IntakeRunnerId: testRunnerId,
Description: utils.Ptr(testDescription),
Labels: testLabels,
Catalog: intake.IntakeCatalog{
Uri: testCatalogURI,
Warehouse: testCatalogWarehouse,
Namespace: utils.Ptr(testCatalogNamespace),
TableName: utils.Ptr(testCatalogTableName),
Partitioning: &testPartitioningType,
PartitionBy: testCatalogPartitionBy,
Auth: &intake.CatalogAuth{
Type: authType,
Dremio: &intake.DremioAuth{
TokenEndpoint: testDremioTokenEndpoint,
PersonalAccessToken: testDremioToken,
},
},
},
}
for _, mod := range mods {
mod(&payload)
}
return payload
}
// fixtureRequest generates an API request for tests
func fixtureRequest(mods ...func(request *intake.ApiCreateIntakeRequest)) intake.ApiCreateIntakeRequest {
request := testClient.DefaultAPI.CreateIntake(testCtx, testProjectId, testRegion)
request = request.CreateIntakePayload(fixtureCreatePayload())
for _, mod := range mods {
mod(&request)
}
return request
}
func TestParseInput(t *testing.T) {
tests := []struct {
description string
flagValues map[string]string
isValid bool
expectedModel *inputModel
}{
{
description: "base",
flagValues: fixtureFlagValues(),
isValid: true,
expectedModel: fixtureInputModel(),
},
{
description: "no values",
flagValues: map[string]string{},
isValid: false,
},
{
description: "project id missing",
flagValues: fixtureFlagValues(func(flagValues map[string]string) {
delete(flagValues, globalflags.ProjectIdFlag)
}),
isValid: false,
},
{
description: "runner-id missing",
flagValues: fixtureFlagValues(func(flagValues map[string]string) {
delete(flagValues, runnerIdFlag)
}),
isValid: false,
},
{
description: "catalog-uri missing",
flagValues: fixtureFlagValues(func(flagValues map[string]string) {
delete(flagValues, catalogURIFlag)
}),
isValid: false,
},
{
description: "catalog-warehouse missing",
flagValues: fixtureFlagValues(func(flagValues map[string]string) {
delete(flagValues, catalogWarehouseFlag)
}),
isValid: false,
},
{
description: "required fields only",
flagValues: map[string]string{
globalflags.ProjectIdFlag: testProjectId,
globalflags.RegionFlag: testRegion,
displayNameFlag: testDisplayName,
runnerIdFlag: testRunnerId,
catalogURIFlag: testCatalogURI,
catalogWarehouseFlag: testCatalogWarehouse,
catalogAuthTypeFlag: testCatalogAuthType,
},
isValid: true,
expectedModel: fixtureInputModel(func(model *inputModel) {
model.Description = nil
model.Labels = nil
model.CatalogNamespace = nil
model.CatalogTableName = nil
model.CatalogPartitioning = nil
model.CatalogPartitionBy = nil
model.DremioTokenEndpoint = nil
model.DremioToken = nil
}),
},
}
for _, tt := range tests {
t.Run(tt.description, func(t *testing.T) {
testutils.TestParseInput(t, NewCmd, func(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel, error) {
return parseInput(p, cmd)
}, tt.expectedModel, nil, tt.flagValues, tt.isValid)
})
}
}
func TestBuildRequest(t *testing.T) {
tests := []struct {
description string
model *inputModel
expectedRequest intake.ApiCreateIntakeRequest
}{
{
description: "base",
model: fixtureInputModel(),
expectedRequest: fixtureRequest(),
},
{
description: "no optionals",
model: fixtureInputModel(func(model *inputModel) {
model.Description = nil
model.Labels = nil
model.CatalogNamespace = nil
model.CatalogTableName = nil
model.CatalogPartitioning = nil
model.CatalogPartitionBy = nil
model.CatalogAuthType = nil
model.DremioTokenEndpoint = nil
model.DremioToken = nil
}),
expectedRequest: fixtureRequest(func(request *intake.ApiCreateIntakeRequest) {
*request = request.CreateIntakePayload(fixtureCreatePayload(func(payload *intake.CreateIntakePayload) {
payload.Description = nil
payload.Labels = nil
payload.Catalog.Namespace = nil
payload.Catalog.TableName = nil
payload.Catalog.PartitionBy = nil
payload.Catalog.Partitioning = nil
payload.Catalog.Auth = nil
}))
}),
},
{
description: "auth type none",
model: fixtureInputModel(func(model *inputModel) {
model.CatalogAuthType = utils.Ptr("none")
model.DremioTokenEndpoint = nil
model.DremioToken = nil
}),
expectedRequest: fixtureRequest(func(request *intake.ApiCreateIntakeRequest) {
*request = request.CreateIntakePayload(fixtureCreatePayload(func(payload *intake.CreateIntakePayload) {
authType := intake.CatalogAuthType("none")
payload.Catalog.Auth.Type = authType
payload.Catalog.Auth.Dremio = nil
}))
}),
},
}
for _, tt := range tests {
t.Run(tt.description, func(t *testing.T) {
request := buildRequest(testCtx, tt.model, testClient)
diff := cmp.Diff(request, tt.expectedRequest,
cmp.AllowUnexported(tt.expectedRequest),
cmpopts.EquateComparable(testCtx),
cmpopts.EquateComparable(testClient.DefaultAPI),
)
if diff != "" {
t.Fatalf("Data does not match: %s", diff)
}
})
}
}
func TestOutputResult(t *testing.T) {
type args struct {
model *inputModel
projectLabel string
resp *intake.IntakeResponse
}
tests := []struct {
name string
args args
wantErr bool
}{
{
name: "default output",
args: args{
model: fixtureInputModel(),
projectLabel: "my-project",
resp: &intake.IntakeResponse{Id: "intake-id-123"},
},
wantErr: false,
},
{
name: "default output - async",
args: args{
model: fixtureInputModel(func(model *inputModel) {
model.Async = true
}),
projectLabel: "my-project",
resp: &intake.IntakeResponse{Id: "intake-id-123"},
},
wantErr: false,
},
{
name: "json output",
args: args{
model: fixtureInputModel(func(model *inputModel) {
model.OutputFormat = print.JSONOutputFormat
}),
resp: &intake.IntakeResponse{Id: "intake-id-123"},
},
wantErr: false,
},
{
name: "nil response - default output",
args: args{
model: fixtureInputModel(),
resp: nil,
},
wantErr: false,
},
{
name: "nil response - json output",
args: args{
model: fixtureInputModel(func(model *inputModel) {
model.OutputFormat = print.JSONOutputFormat
}),
resp: nil,
},
wantErr: false,
},
}
p := print.NewPrinter()
p.Cmd = NewCmd(&types.CmdParams{Printer: p})
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if err := outputResult(p, tt.args.model, tt.args.projectLabel, tt.args.resp); (err != nil) != tt.wantErr {
t.Errorf("outputResult() error = %v, wantErr %v", err, tt.wantErr)
}
})
}
}