fix(audit-logs): add HTTPS scheme to URLs and update compliance lock dependencies

Author: mahauber

src/modules/management/3-object-storage.tf

@@ -1,13 +1,3 @@
-####################
-## OBJECT STORAGE ##
-####################
-
-resource "stackit_objectstorage_compliance_lock" "this" {
-  count = try(var.audit_logs.s3_object_lock, false) ? 1 : 0
-
-  project_id = stackit_resourcemanager_project.this.project_id
-}
-
 #############
 ## BUCKETS ##
 #############
@@ -26,11 +16,22 @@ resource "stackit_objectstorage_bucket" "tfstate" {
   ]
 }
 
+resource "stackit_objectstorage_compliance_lock" "this" {
+  count = try(var.audit_logs.s3_object_lock, false) ? 1 : 0
+
+  project_id = stackit_resourcemanager_project.this.project_id
+
+  depends_on = [
+    stackit_objectstorage_bucket.default,
+    stackit_objectstorage_bucket.tfstate,
+  ]
+}
+
 resource "stackit_objectstorage_bucket" "audit_logs" {
   name       = "${var.naming_pattern}-audit-logs"
   project_id = stackit_resourcemanager_project.this.project_id
 
-  object_lock = local.audit_object_lock ? true : null
+  object_lock = try(var.audit_logs.s3_object_lock, false) ? true : null
 
   depends_on = [
     stackit_objectstorage_bucket.tfstate,       # "project.create_conflict","msg":"Two concurrent calls try to create the same project"}]}
@@ -39,7 +40,7 @@ resource "stackit_objectstorage_bucket" "audit_logs" {
 }
 
 resource "stackit_objectstorage_default_retention" "audit_logs" {
-  count = local.audit_object_lock ? 1 : 0
+  count = try(var.audit_logs.s3_object_lock, false) ? 1 : 0
 
   project_id  = stackit_resourcemanager_project.this.project_id
   bucket_name = stackit_objectstorage_bucket.audit_logs.name

src/modules/management/6-audit-logs.tf

@@ -55,7 +55,7 @@ resource "stackit_telemetryrouter_destination" "audit_logs" {
   config = {
     config_type = "OpenTelemetry"
     opentelemetry = {
-      uri          = stackit_logs_instance.audit[0].ingest_otlp_url
+      uri          = "https://${stackit_logs_instance.audit[0].ingest_otlp_url}"
       bearer_token = stackit_logs_access_token.audit_write[0].access_token
     }
   }
@@ -128,9 +128,10 @@ resource "vault_kv_secret_v2" "audit_logs" {
   delete_all_versions = true
   data_json = jsonencode(
     {
-      INGEST_OTLP_URL = stackit_logs_instance.audit[0].ingest_otlp_url
-      QUERY_URL       = stackit_logs_instance.audit[0].query_url
-      DATASOURCE_URL  = stackit_logs_instance.audit[0].datasource_url
+      # The API returns these without a scheme; store them ready to use.
+      INGEST_OTLP_URL = "https://${stackit_logs_instance.audit[0].ingest_otlp_url}"
+      QUERY_URL       = "https://${stackit_logs_instance.audit[0].query_url}"
+      DATASOURCE_URL  = "https://${stackit_logs_instance.audit[0].datasource_url}"
       WRITE_TOKEN     = stackit_logs_access_token.audit_write[0].access_token
       READ_TOKEN      = stackit_logs_access_token.audit_read[0].access_token
       ROUTER_TOKEN    = stackit_telemetryrouter_access_token.audit_link[0].access_token