Adjust TFLint warning policy and fix deprecated interpolation

Closes #4

Author: lweberru

.github/workflows/tflint.yml

@@ -29,8 +29,12 @@ jobs:
       - name: Init TFLint
         run: tflint --init
 
-      - name: Run TFLint
-        run: tflint --recursive --format compact
+      - name: Run TFLint (blocking except unused declarations)
+        run: tflint --recursive --format compact --minimum-failure-severity=warning --disable-rule=terraform_unused_declarations --disable-rule=terraform_required_providers
+
+      - name: Run TFLint (unused declarations report only)
+        continue-on-error: true
+        run: tflint --recursive --format compact --only=terraform_unused_declarations
 
       - name: Validate STACKIT flavors (live)
         run: python3 scripts/validate_stackit_flavors.py

modules/landing-zone/5-bucket.tf

@@ -38,8 +38,8 @@ resource "vault_kv_secret_v2" "object_storage_credentials" {
   delete_all_versions = true
   data_json = jsonencode(
     {
-      ACCESS_KEY        = "${stackit_objectstorage_credential.this.access_key}",
-      SECRET_ACCESS_KEY = "${stackit_objectstorage_credential.this.secret_access_key}"
+      ACCESS_KEY        = stackit_objectstorage_credential.this.access_key,
+      SECRET_ACCESS_KEY = stackit_objectstorage_credential.this.secret_access_key
     }
   )
 }

modules/management/3-bucket.tf

@@ -43,8 +43,8 @@ resource "vault_kv_secret_v2" "object_storage_credentials" {
   delete_all_versions = true
   data_json = jsonencode(
     {
-      ACCESS_KEY        = "${stackit_objectstorage_credential.this.access_key}",
-      SECRET_ACCESS_KEY = "${stackit_objectstorage_credential.this.secret_access_key}"
+      ACCESS_KEY        = stackit_objectstorage_credential.this.access_key,
+      SECRET_ACCESS_KEY = stackit_objectstorage_credential.this.secret_access_key
     }
   )
 }