adjust acceptance tests

Author: rubenhoenle

docs/data-sources/resourcemanager_project.md

@@ -32,5 +32,4 @@ data "stackit_resourcemanager_project" "example" {
 - `id` (String) Terraform's internal data source. ID. It is structured as "`container_id`".
 - `labels` (Map of String) Labels are key-value string pairs which can be attached to a resource container. A label key must match the regex [A-ZÄÜÖa-zäüöß0-9_-]{1,64}. A label value must match the regex ^$|[A-ZÄÜÖa-zäüöß0-9_-]{1,64}
 - `name` (String) Project name.
-- `owner_email` (String) Email address of the owner of the project. This value is only considered during creation. Changing it afterwards will have no effect.
 - `parent_container_id` (String) Parent resource identifier. Both container ID (user-friendly) and UUID are supported

stackit/internal/services/resourcemanager/project/datasource.go

@@ -84,7 +84,6 @@ func (d *projectDataSource) Schema(_ context.Context, _ datasource.SchemaRequest
 		"parent_container_id": "Parent resource identifier. Both container ID (user-friendly) and UUID are supported",
 		"name":                "Project name.",
 		"labels":              `Labels are key-value string pairs which can be attached to a resource container. A label key must match the regex [A-ZÄÜÖa-zäüöß0-9_-]{1,64}. A label value must match the regex ^$|[A-ZÄÜÖa-zäüöß0-9_-]{1,64}`,
-		"owner_email":         "Email address of the owner of the project. This value is only considered during creation. Changing it afterwards will have no effect.",
 	}
 
 	resp.Schema = schema.Schema{
@@ -140,10 +139,6 @@ func (d *projectDataSource) Schema(_ context.Context, _ datasource.SchemaRequest
 					),
 				},
 			},
-			"owner_email": schema.StringAttribute{
-				Description: descriptions["owner_email"],
-				Computed:    true,
-			},
 		},
 	}
 }

stackit/internal/services/resourcemanager/resourcemanager_acc_test.go

@@ -3,15 +3,13 @@ package resourcemanager_test
 import (
 	"context"
 	"fmt"
-	"strings"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-testing/helper/acctest"
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 	"github.com/hashicorp/terraform-plugin-testing/terraform"
 	"github.com/stackitcloud/stackit-sdk-go/core/config"
 	"github.com/stackitcloud/stackit-sdk-go/core/utils"
-	"github.com/stackitcloud/stackit-sdk-go/services/authorization"
 	"github.com/stackitcloud/stackit-sdk-go/services/resourcemanager"
 	"github.com/stackitcloud/stackit-sdk-go/services/resourcemanager/wait"
 	"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/testutil"
@@ -26,19 +24,7 @@ var projectResource = map[string]string{
 	"new_label":           "a-label",
 }
 
-func membersConfig(members []authorization.Member) string {
-	membersConfig := make([]string, 0, len(members))
-	for _, m := range members {
-		memberConfig := fmt.Sprintf(`{
-			subject = "%s"
-			role = "%s"
-		}`, *m.Subject, *m.Role)
-		membersConfig = append(membersConfig, memberConfig)
-	}
-	return strings.Join(membersConfig, ",\n")
-}
-
-func resourceConfig(name string, label *string, members string) string {
+func resourceConfig(name string, label *string) string {
 	labelConfig := ""
 	if label != nil {
 		labelConfig = fmt.Sprintf("new_label = %q", *label)
@@ -53,19 +39,13 @@ func resourceConfig(name string, label *string, members string) string {
 						"billing_reference" = "%[4]s"
 						%[5]s
 					}
-					members = [
-						%[7]s
-					]
-					owner_email = "%[8]s"
+					owner_email = "%[7]s"
 				}
 
 				resource "stackit_resourcemanager_project" "parent_by_uuid" {
 					parent_container_id = "%[6]s"
 					name = "%[3]s-uuid"
-					members = [
-						%[7]s
-					]
-                    owner_email = "%[8]s"
+                    owner_email = "%[7]s"
 				}
 				`,
 		testutil.ResourceManagerProviderConfig(),
@@ -74,26 +54,18 @@ func resourceConfig(name string, label *string, members string) string {
 		projectResource["billing_reference"],
 		labelConfig,
 		projectResource["parent_uuid"],
-		members,
 		testutil.TestProjectServiceAccountEmail,
 	)
 }
 
 func TestAccResourceManagerResource(t *testing.T) {
-	initialMembersConfig := membersConfig([]authorization.Member{
-		{
-			Subject: &testutil.TestProjectUserEmail,
-			Role:    utils.Ptr("owner"),
-		},
-	})
-
 	resource.Test(t, resource.TestCase{
 		ProtoV6ProviderFactories: testutil.TestAccProtoV6ProviderFactories,
 		CheckDestroy:             testAccCheckResourceManagerDestroy,
 		Steps: []resource.TestStep{
 			// Creation
 			{
-				Config: resourceConfig(projectResource["name"], nil, initialMembersConfig),
+				Config: resourceConfig(projectResource["name"], nil),
 				Check: resource.ComposeAggregateTestCheckFunc(
 					// Parent container id project data
 					resource.TestCheckResourceAttrSet("stackit_resourcemanager_project.parent_by_container", "container_id"),
@@ -128,7 +100,7 @@ func TestAccResourceManagerResource(t *testing.T) {
 						project_id = stackit_resourcemanager_project.parent_by_container.project_id
 					}
 					`,
-					resourceConfig(projectResource["name"], nil, initialMembersConfig),
+					resourceConfig(projectResource["name"], nil),
 				),
 				Check: resource.ComposeAggregateTestCheckFunc(
 					// Container project data
@@ -139,6 +111,7 @@ func TestAccResourceManagerResource(t *testing.T) {
 					resource.TestCheckResourceAttrSet("data.stackit_resourcemanager_project.project_by_container", "parent_container_id"),
 					resource.TestCheckResourceAttr("data.stackit_resourcemanager_project.project_by_container", "labels.%", "1"),
 					resource.TestCheckResourceAttr("data.stackit_resourcemanager_project.project_by_container", "labels.billing_reference", projectResource["billing_reference"]),
+					resource.TestCheckResourceAttr("data.stackit_resourcemanager_project.project_by_container", "owner_email", testutil.TestProjectServiceAccountEmail),
 
 					// UUID project data
 					resource.TestCheckResourceAttrSet("data.stackit_resourcemanager_project.project_by_uuid", "id"),
@@ -148,6 +121,7 @@ func TestAccResourceManagerResource(t *testing.T) {
 					resource.TestCheckResourceAttrSet("data.stackit_resourcemanager_project.project_by_uuid", "parent_container_id"),
 					resource.TestCheckResourceAttr("data.stackit_resourcemanager_project.project_by_uuid", "labels.%", "1"),
 					resource.TestCheckResourceAttr("data.stackit_resourcemanager_project.project_by_uuid", "labels.billing_reference", projectResource["billing_reference"]),
+					resource.TestCheckResourceAttr("data.stackit_resourcemanager_project.project_by_uuid", "owner_email", testutil.TestProjectServiceAccountEmail),
 
 					// Both project data
 					resource.TestCheckResourceAttrSet("data.stackit_resourcemanager_project.project_by_both", "id"),
@@ -157,6 +131,7 @@ func TestAccResourceManagerResource(t *testing.T) {
 					resource.TestCheckResourceAttrSet("data.stackit_resourcemanager_project.project_by_both", "parent_container_id"),
 					resource.TestCheckResourceAttr("data.stackit_resourcemanager_project.project_by_both", "labels.%", "1"),
 					resource.TestCheckResourceAttr("data.stackit_resourcemanager_project.project_by_both", "labels.billing_reference", projectResource["billing_reference"]),
+					resource.TestCheckResourceAttr("data.stackit_resourcemanager_project.project_by_both", "owner_email", testutil.TestProjectServiceAccountEmail),
 				),
 			},
 			// Import
@@ -178,11 +153,11 @@ func TestAccResourceManagerResource(t *testing.T) {
 				ImportStateVerify: true,
 				// The owner_email attributes don't exist in the
 				// API, therefore there is no value for it during import.
-				ImportStateVerifyIgnore: []string{"owner_email", "members"},
+				ImportStateVerifyIgnore: []string{"owner_email"},
 			},
 			// Update
 			{
-				Config: resourceConfig(fmt.Sprintf("%s-new", projectResource["name"]), utils.Ptr("a-label"), initialMembersConfig),
+				Config: resourceConfig(fmt.Sprintf("%s-new", projectResource["name"]), utils.Ptr("a-label")),
 				Check: resource.ComposeAggregateTestCheckFunc(
 					// Project data
 					resource.TestCheckResourceAttrSet("stackit_resourcemanager_project.parent_by_container", "container_id"),
@@ -191,6 +166,7 @@ func TestAccResourceManagerResource(t *testing.T) {
 					resource.TestCheckResourceAttr("stackit_resourcemanager_project.parent_by_container", "labels.%", "2"),
 					resource.TestCheckResourceAttr("stackit_resourcemanager_project.parent_by_container", "labels.billing_reference", projectResource["billing_reference"]),
 					resource.TestCheckResourceAttr("stackit_resourcemanager_project.parent_by_container", "labels.new_label", projectResource["new_label"]),
+					resource.TestCheckResourceAttr("stackit_resourcemanager_project.parent_by_container", "owner_email", testutil.TestProjectServiceAccountEmail),
 				),
 			},
 			// Deletion is done by the framework implicitly