fixed or flagged linter findings

Author: Manuelvaas

stackit/internal/services/access_token/ephemeral_resource_test.go

@@ -64,7 +64,7 @@ func writeTempPEMFile(t *testing.T, pemContent string) string {
 	}
 
 	t.Cleanup(func() {
-		_ = os.Remove(tmpFile.Name())
+		_ = os.Remove(tmpFile.Name()) //nolint:gosec // Filename safely generated through os.CreateTemp
 	})
 
 	return tmpFile.Name()

stackit/internal/services/iaas/image/resource.go

@@ -864,15 +864,15 @@ func uploadImage(ctx context.Context, diags *diag.Diagnostics, filePath, uploadU
 		return fmt.Errorf("stat file: %w", err)
 	}
 
-	req, err := http.NewRequest(http.MethodPut, uploadURL, bufio.NewReader(file))
+	req, err := http.NewRequest(http.MethodPut, uploadURL, bufio.NewReader(file)) //nolint:gosec // file upload
 	if err != nil {
 		return fmt.Errorf("create upload request: %w", err)
 	}
 	req.Header.Set("Content-Type", "application/octet-stream")
 	req.ContentLength = stat.Size()
 
 	client := &http.Client{}
-	resp, err := client.Do(req)
+	resp, err := client.Do(req) //nolint:gosec // file upload
 	if err != nil {
 		return fmt.Errorf("upload image: %w", err)
 	}

stackit/internal/services/postgresflex/database/resource.go

@@ -273,7 +273,7 @@ func (r *databaseResource) Read(ctx context.Context, req resource.ReadRequest, r
 	databaseResp, err := getDatabase(ctx, r.client, projectId, region, instanceId, databaseId)
 	if err != nil {
 		oapiErr, ok := err.(*oapierror.GenericOpenAPIError) //nolint:errorlint //complaining that error.As should be used to catch wrapped errors, but this error should not be wrapped
-		if (ok && oapiErr.StatusCode == http.StatusNotFound) || errors.Is(err, databaseNotFoundErr) {
+		if (ok && oapiErr.StatusCode == http.StatusNotFound) || errors.Is(err, errDatabaseNotFound) {
 			resp.State.RemoveResource(ctx)
 			return
 		}
@@ -418,7 +418,7 @@ func toCreatePayload(model *Model) (*postgresflex.CreateDatabasePayload, error)
 	}, nil
 }
 
-var databaseNotFoundErr = errors.New("database not found")
+var errDatabaseNotFound = errors.New("database not found")
 
 // The API does not have a GetDatabase endpoint, only ListDatabases
 func getDatabase(ctx context.Context, client *postgresflex.APIClient, projectId, region, instanceId, databaseId string) (*postgresflex.InstanceDatabase, error) {
@@ -434,5 +434,5 @@ func getDatabase(ctx context.Context, client *postgresflex.APIClient, projectId,
 			return &database, nil
 		}
 	}
-	return nil, databaseNotFoundErr
+	return nil, errDatabaseNotFound
 }

stackit/internal/services/serverbackup/schedule/resource.go

@@ -539,7 +539,7 @@ func (r *scheduleResource) disableBackupsService(ctx context.Context, model *Mod
 	if err != nil {
 		return fmt.Errorf("list backups: %w", err)
 	}
-	if *backups.Items != nil && len(*backups.Items) > 0 {
+	if len(*backups.Items) > 0 {
 		tflog.Debug(ctx, "Backups found - will not disable server backup service")
 		return nil
 	}