Skip to content

Commit 5cbcbec

Browse files
authored
fix(secretsmanager): remove RequiresReplace for secretsmanager description (#1495)
relates to STACKITTPR-649 and #882
1 parent 4616b58 commit 5cbcbec

3 files changed

Lines changed: 8 additions & 6 deletions

File tree

stackit/internal/services/secretsmanager/secretsmanager_acc_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ func configVarsMaxUpdated() config.Variables {
6262
tempConfig["write_enabled"] = config.BoolVariable(false)
6363
tempConfig["use_kms_key"] = config.BoolVariable(false)
6464
tempConfig["acl2"] = config.StringVariable("10.100.2.0/24")
65+
tempConfig["user_description"] = config.StringVariable("tf-acc-" + acctest.RandStringFromCharSet(8, acctest.CharSetAlpha))
6566
return tempConfig
6667
}
6768

stackit/internal/services/secretsmanager/user/resource.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,6 @@ func (r *userResource) Schema(_ context.Context, _ resource.SchemaRequest, resp
142142
"description": schema.StringAttribute{
143143
Description: descriptions["description"],
144144
Required: true,
145-
PlanModifiers: []planmodifier.String{
146-
stringplanmodifier.RequiresReplace(),
147-
},
148145
},
149146
"write_enabled": schema.BoolAttribute{
150147
Description: descriptions["write_enabled"],
@@ -415,7 +412,8 @@ func toUpdatePayload(model *Model) (*secretsmanager.UpdateUserPayload, error) {
415412
return nil, fmt.Errorf("nil model")
416413
}
417414
return &secretsmanager.UpdateUserPayload{
418-
Write: conversion.BoolValueToPointer(model.WriteEnabled),
415+
Description: conversion.StringValueToPointer(model.Description),
416+
Write: conversion.BoolValueToPointer(model.WriteEnabled),
419417
}, nil
420418
}
421419

stackit/internal/services/secretsmanager/user/resource_test.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,17 +234,20 @@ func TestToUpdatePayload(t *testing.T) {
234234
"default_values",
235235
&Model{},
236236
&secretsmanager.UpdateUserPayload{
237-
Write: nil,
237+
Description: nil,
238+
Write: nil,
238239
},
239240
true,
240241
},
241242
{
242243
"simple_values",
243244
&Model{
245+
Description: types.StringValue(""),
244246
WriteEnabled: types.BoolValue(false),
245247
},
246248
&secretsmanager.UpdateUserPayload{
247-
Write: new(false),
249+
Description: new(""),
250+
Write: new(false),
248251
},
249252
true,
250253
},

0 commit comments

Comments
 (0)