breaking_change(rabbitmq): TlsProtocols is now an array of strings instead of a single string

Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>

Author: Fyusel

docs/data-sources/rabbitmq_instance.md

@@ -58,4 +58,4 @@ Read-Only:
 - `sgw_acl` (String) Comma separated list of IP networks in CIDR notation which are allowed to access this instance.
 - `syslog` (List of String) List of syslog servers to send logs to.
 - `tls_ciphers` (List of String) List of TLS ciphers to use.
-- `tls_protocols` (String) TLS protocol to use.
+- `tls_protocols` (List of String) TLS protocol versions to use.

docs/resources/rabbitmq_instance.md

@@ -75,4 +75,4 @@ Optional:
 - `sgw_acl` (String) Comma separated list of IP networks in CIDR notation which are allowed to access this instance.
 - `syslog` (List of String) List of syslog servers to send logs to.
 - `tls_ciphers` (List of String) List of TLS ciphers to use.
-- `tls_protocols` (String) TLS protocol to use.
+- `tls_protocols` (List of String) TLS protocol versions to use.

stackit/internal/services/rabbitmq/instance/datasource.go

@@ -81,7 +81,7 @@ func (r *instanceDataSource) Schema(_ context.Context, _ datasource.SchemaReques
 		"roles":                  "List of roles to assign to the instance.",
 		"syslog":                 "List of syslog servers to send logs to.",
 		"tls_ciphers":            "List of TLS ciphers to use.",
-		"tls_protocols":          "TLS protocol to use.",
+		"tls_protocols":          "TLS protocol versions to use.",
 	}
 
 	resp.Schema = schema.Schema{
@@ -177,8 +177,9 @@ func (r *instanceDataSource) Schema(_ context.Context, _ datasource.SchemaReques
 						ElementType: types.StringType,
 						Computed:    true,
 					},
-					"tls_protocols": schema.StringAttribute{
+					"tls_protocols": schema.ListAttribute{
 						Description: parametersDescriptions["tls_protocols"],
+						ElementType: types.StringType,
 						Computed:    true,
 					},
 				},

stackit/internal/services/rabbitmq/instance/resource.go

@@ -67,7 +67,7 @@ type parametersModel struct {
 	Roles                types.List   `tfsdk:"roles"`
 	Syslog               types.List   `tfsdk:"syslog"`
 	TlsCiphers           types.List   `tfsdk:"tls_ciphers"`
-	TlsProtocols         types.String `tfsdk:"tls_protocols"`
+	TlsProtocols         types.List   `tfsdk:"tls_protocols"`
 }
 
 // Types corresponding to parametersModel
@@ -84,7 +84,7 @@ var parametersTypes = map[string]attr.Type{
 	"roles":                  basetypes.ListType{ElemType: types.StringType},
 	"syslog":                 basetypes.ListType{ElemType: types.StringType},
 	"tls_ciphers":            basetypes.ListType{ElemType: types.StringType},
-	"tls_protocols":          basetypes.StringType{},
+	"tls_protocols":          basetypes.ListType{ElemType: types.StringType},
 }
 
 // NewInstanceResource is a helper function to simplify the provider implementation.
@@ -144,7 +144,7 @@ func (r *instanceResource) Schema(_ context.Context, _ resource.SchemaRequest, r
 		"roles":                  "List of roles to assign to the instance.",
 		"syslog":                 "List of syslog servers to send logs to.",
 		"tls_ciphers":            "List of TLS ciphers to use.",
-		"tls_protocols":          "TLS protocol to use.",
+		"tls_protocols":          "TLS protocol versions to use.",
 	}
 
 	resp.Schema = schema.Schema{
@@ -274,8 +274,9 @@ func (r *instanceResource) Schema(_ context.Context, _ resource.SchemaRequest, r
 						Optional:    true,
 						Computed:    true,
 					},
-					"tls_protocols": schema.StringAttribute{
+					"tls_protocols": schema.ListAttribute{
 						Description: parametersDescriptions["tls_protocols"],
+						ElementType: types.StringType,
 						Optional:    true,
 						Computed:    true,
 					},
@@ -749,7 +750,6 @@ func toInstanceParams(parameters *parametersModel) (*rabbitmq.InstanceParameters
 	payloadParams.MetricsFrequency = conversion.Int64ValueToPointer(parameters.MetricsFrequency)
 	payloadParams.MetricsPrefix = conversion.StringValueToPointer(parameters.MetricsPrefix)
 	payloadParams.MonitoringInstanceId = conversion.StringValueToPointer(parameters.MonitoringInstanceId)
-	payloadParams.TlsProtocols = rabbitmq.InstanceParametersGetTlsProtocolsAttributeType(conversion.StringValueToPointer(parameters.TlsProtocols))
 
 	var err error
 	payloadParams.Plugins, err = conversion.StringListToPointer(parameters.Plugins)
@@ -772,6 +772,11 @@ func toInstanceParams(parameters *parametersModel) (*rabbitmq.InstanceParameters
 		return nil, fmt.Errorf("converting tls_ciphers: %w", err)
 	}
 
+	payloadParams.TlsProtocols, err = conversion.StringListToPointer(parameters.TlsProtocols)
+	if err != nil {
+		return nil, fmt.Errorf("converting tls_protocol_versions: %w", err)
+	}
+
 	return payloadParams, nil
 }
 

stackit/internal/services/rabbitmq/instance/resource_test.go

@@ -37,7 +37,10 @@ var fixtureModelParameters = types.ObjectValueMust(parametersTypes, map[string]a
 		types.StringValue("ciphers1"),
 		types.StringValue("ciphers2"),
 	}),
-	"tls_protocols": types.StringValue(string(rabbitmq.INSTANCEPARAMETERSTLS_PROTOCOLS__2)),
+	"tls_protocols": types.ListValueMust(types.StringType, []attr.Value{
+		types.StringValue("tlsv1.2"),
+		types.StringValue("tlsv1.3"),
+	}),
 })
 
 var fixtureInstanceParameters = rabbitmq.InstanceParameters{
@@ -53,7 +56,7 @@ var fixtureInstanceParameters = rabbitmq.InstanceParameters{
 	Roles:                &[]string{"role1", "role2"},
 	Syslog:               &[]string{"syslog", "syslog2"},
 	TlsCiphers:           &[]string{"ciphers1", "ciphers2"},
-	TlsProtocols:         rabbitmq.INSTANCEPARAMETERSTLS_PROTOCOLS__2.Ptr(),
+	TlsProtocols:         &[]string{"tlsv1.2", "tlsv1.3"},
 }
 
 func TestMapFields(t *testing.T) {
@@ -105,7 +108,7 @@ func TestMapFields(t *testing.T) {
 					"roles":                  []string{"role1", "role2"},
 					"syslog":                 []string{"syslog", "syslog2"},
 					"tls-ciphers":            []string{"ciphers1", "ciphers2"},
-					"tls-protocols":          string(rabbitmq.INSTANCEPARAMETERSTLS_PROTOCOLS__2),
+					"tls-protocols":          []string{"tlsv1.2", "tlsv1.3"},
 				},
 			},
 			Model{