Skip to content

Commit a109639

Browse files
authored
Fix inconsistent values issue (#1283)
1 parent 717323f commit a109639

File tree

2 files changed

+2
-22
lines changed

2 files changed

+2
-22
lines changed

stackit/internal/services/observability/instance/resource.go

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ func getRouteNestedObjectAux(isDatasource bool, level, limit int) schema.ListNes
305305
"continue": schema.BoolAttribute{
306306
Description: routeDescriptions["continue"],
307307
Optional: !isDatasource,
308-
Computed: isDatasource,
308+
Computed: true,
309309
},
310310
"group_by": schema.ListAttribute{
311311
Description: routeDescriptions["group_by"],
@@ -317,17 +317,11 @@ func getRouteNestedObjectAux(isDatasource bool, level, limit int) schema.ListNes
317317
Description: routeDescriptions["group_interval"],
318318
Optional: !isDatasource,
319319
Computed: true,
320-
PlanModifiers: []planmodifier.String{
321-
stringplanmodifier.UseStateForUnknown(),
322-
},
323320
},
324321
"group_wait": schema.StringAttribute{
325322
Description: routeDescriptions["group_wait"],
326323
Optional: !isDatasource,
327324
Computed: true,
328-
PlanModifiers: []planmodifier.String{
329-
stringplanmodifier.UseStateForUnknown(),
330-
},
331325
},
332326
"match": schema.MapAttribute{
333327
Description: routeDescriptions["match"],
@@ -358,9 +352,6 @@ func getRouteNestedObjectAux(isDatasource bool, level, limit int) schema.ListNes
358352
Description: routeDescriptions["repeat_interval"],
359353
Optional: !isDatasource,
360354
Computed: true,
361-
PlanModifiers: []planmodifier.String{
362-
stringplanmodifier.UseStateForUnknown(),
363-
},
364355
},
365356
}
366357

stackit/internal/services/observability/instance/resource_test.go

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ import (
88
"github.com/hashicorp/terraform-plugin-framework-validators/listvalidator"
99
"github.com/hashicorp/terraform-plugin-framework/attr"
1010
"github.com/hashicorp/terraform-plugin-framework/resource/schema"
11-
"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
12-
"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
1311
"github.com/hashicorp/terraform-plugin-framework/schema/validator"
1412
"github.com/hashicorp/terraform-plugin-framework/types"
1513
"github.com/hashicorp/terraform-plugin-framework/types/basetypes"
@@ -297,7 +295,7 @@ func fixtureRouteAttributeSchema(route *schema.ListNestedAttribute, isDatasource
297295
"continue": schema.BoolAttribute{
298296
Description: routeDescriptions["continue"],
299297
Optional: !isDatasource,
300-
Computed: isDatasource,
298+
Computed: true,
301299
},
302300
"group_by": schema.ListAttribute{
303301
Description: routeDescriptions["group_by"],
@@ -309,17 +307,11 @@ func fixtureRouteAttributeSchema(route *schema.ListNestedAttribute, isDatasource
309307
Description: routeDescriptions["group_interval"],
310308
Optional: !isDatasource,
311309
Computed: true,
312-
PlanModifiers: []planmodifier.String{
313-
stringplanmodifier.UseStateForUnknown(),
314-
},
315310
},
316311
"group_wait": schema.StringAttribute{
317312
Description: routeDescriptions["group_wait"],
318313
Optional: !isDatasource,
319314
Computed: true,
320-
PlanModifiers: []planmodifier.String{
321-
stringplanmodifier.UseStateForUnknown(),
322-
},
323315
},
324316
"match": schema.MapAttribute{
325317
Description: routeDescriptions["match"],
@@ -350,9 +342,6 @@ func fixtureRouteAttributeSchema(route *schema.ListNestedAttribute, isDatasource
350342
Description: routeDescriptions["repeat_interval"],
351343
Optional: !isDatasource,
352344
Computed: true,
353-
PlanModifiers: []planmodifier.String{
354-
stringplanmodifier.UseStateForUnknown(),
355-
},
356345
},
357346
}
358347
if route != nil {

0 commit comments

Comments
 (0)