Skip to content

Commit c313175

Browse files
authored
chore(serviceenablement): switch to new SDK structure (#1398)
relates to STACKITTPR-577
1 parent 8c26284 commit c313175

6 files changed

Lines changed: 24 additions & 22 deletions

File tree

stackit/internal/services/edgecloud/instance/resource.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ import (
2020
"github.com/stackitcloud/stackit-sdk-go/core/oapierror"
2121
edge "github.com/stackitcloud/stackit-sdk-go/services/edge/v1beta1api"
2222
edgewait "github.com/stackitcloud/stackit-sdk-go/services/edge/v1beta1api/wait"
23-
"github.com/stackitcloud/stackit-sdk-go/services/serviceenablement"
24-
enablementWait "github.com/stackitcloud/stackit-sdk-go/services/serviceenablement/wait"
23+
serviceenablement "github.com/stackitcloud/stackit-sdk-go/services/serviceenablement/v2api"
24+
enablementWait "github.com/stackitcloud/stackit-sdk-go/services/serviceenablement/v2api/wait"
2525

2626
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/conversion"
2727
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/core"
@@ -251,13 +251,13 @@ func (i *instanceResource) Create(ctx context.Context, req resource.CreateReques
251251
ctx = tflog.SetField(ctx, "region", region)
252252

253253
// If the service edge-cloud is not enabled, enable it
254-
err := i.enablementClient.EnableServiceRegional(ctx, region, projectId, utils.EdgecloudServiceId).Execute()
254+
err := i.enablementClient.DefaultAPI.EnableServiceRegional(ctx, region, projectId, utils.EdgecloudServiceId).Execute()
255255
if err != nil {
256256
core.LogAndAddError(ctx, &resp.Diagnostics, "Error creating instance", fmt.Sprintf("Calling API to enable edge-cloud: %v", err))
257257
return
258258
}
259259

260-
_, err = enablementWait.EnableServiceWaitHandler(ctx, i.enablementClient, region, projectId, utils.EdgecloudServiceId).WaitWithContext(ctx)
260+
_, err = enablementWait.EnableServiceWaitHandler(ctx, i.enablementClient.DefaultAPI, region, projectId, utils.EdgecloudServiceId).WaitWithContext(ctx)
261261
if err != nil {
262262
core.LogAndAddError(ctx, &resp.Diagnostics, "Error creating instance", fmt.Sprintf("Wait for edge-cloud enablement: %v", err))
263263
return

stackit/internal/services/modelserving/token/resource.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,11 @@ import (
2121
"github.com/hashicorp/terraform-plugin-framework/types"
2222
"github.com/hashicorp/terraform-plugin-log/tflog"
2323
"github.com/stackitcloud/stackit-sdk-go/core/oapierror"
24+
2425
modelserving "github.com/stackitcloud/stackit-sdk-go/services/modelserving/v1api"
2526
"github.com/stackitcloud/stackit-sdk-go/services/modelserving/v1api/wait"
26-
"github.com/stackitcloud/stackit-sdk-go/services/serviceenablement"
27-
serviceEnablementWait "github.com/stackitcloud/stackit-sdk-go/services/serviceenablement/wait"
27+
serviceenablement "github.com/stackitcloud/stackit-sdk-go/services/serviceenablement/v2api"
28+
serviceEnablementWait "github.com/stackitcloud/stackit-sdk-go/services/serviceenablement/v2api/wait"
2829

2930
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/conversion"
3031
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/core"
@@ -247,7 +248,7 @@ func (r *tokenResource) Create(ctx context.Context, req resource.CreateRequest,
247248
ctx = tflog.SetField(ctx, "region", region)
248249

249250
// If AI model serving is not enabled, enable it
250-
err := r.serviceEnablementClient.EnableServiceRegional(ctx, region, projectId, utils.ModelServingServiceId).
251+
err := r.serviceEnablementClient.DefaultAPI.EnableServiceRegional(ctx, region, projectId, utils.ModelServingServiceId).
251252
Execute()
252253
if err != nil {
253254
var oapiErr *oapierror.GenericOpenAPIError
@@ -268,7 +269,7 @@ func (r *tokenResource) Create(ctx context.Context, req resource.CreateRequest,
268269
return
269270
}
270271

271-
_, err = serviceEnablementWait.EnableServiceWaitHandler(ctx, r.serviceEnablementClient, region, projectId, utils.ModelServingServiceId).
272+
_, err = serviceEnablementWait.EnableServiceWaitHandler(ctx, r.serviceEnablementClient.DefaultAPI, region, projectId, utils.ModelServingServiceId).
272273
WaitWithContext(ctx)
273274
if err != nil {
274275
core.LogAndAddError(

stackit/internal/services/serviceenablement/utils/util.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import (
66

77
"github.com/hashicorp/terraform-plugin-framework/diag"
88
"github.com/stackitcloud/stackit-sdk-go/core/config"
9-
"github.com/stackitcloud/stackit-sdk-go/services/serviceenablement"
9+
serviceenablement "github.com/stackitcloud/stackit-sdk-go/services/serviceenablement/v2api"
1010

1111
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/core"
1212
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils"
@@ -19,8 +19,6 @@ func ConfigureClient(ctx context.Context, providerData *core.ProviderData, diags
1919
}
2020
if providerData.ServiceEnablementCustomEndpoint != "" {
2121
apiClientConfigOptions = append(apiClientConfigOptions, config.WithEndpoint(providerData.ServiceEnablementCustomEndpoint))
22-
} else {
23-
apiClientConfigOptions = append(apiClientConfigOptions, config.WithRegion(providerData.GetRegion()))
2422
}
2523
apiClient, err := serviceenablement.NewAPIClient(apiClientConfigOptions...)
2624
if err != nil {

stackit/internal/services/serviceenablement/utils/util_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import (
99
"github.com/hashicorp/terraform-plugin-framework/diag"
1010
sdkClients "github.com/stackitcloud/stackit-sdk-go/core/clients"
1111
"github.com/stackitcloud/stackit-sdk-go/core/config"
12-
"github.com/stackitcloud/stackit-sdk-go/services/serviceenablement"
12+
serviceenablement "github.com/stackitcloud/stackit-sdk-go/services/serviceenablement/v2api"
1313

1414
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/core"
1515
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils"
@@ -47,7 +47,6 @@ func TestConfigureClient(t *testing.T) {
4747
expected: func() *serviceenablement.APIClient {
4848
apiClient, err := serviceenablement.NewAPIClient(
4949
utils.UserAgentConfigOption(testVersion),
50-
config.WithRegion("eu01"),
5150
)
5251
if err != nil {
5352
t.Errorf("error configuring client: %v", err)

stackit/internal/services/ske/cluster/resource.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,13 @@ import (
3737
"github.com/hashicorp/terraform-plugin-log/tflog"
3838
"github.com/stackitcloud/stackit-sdk-go/core/oapierror"
3939
sdkUtils "github.com/stackitcloud/stackit-sdk-go/core/utils"
40-
"github.com/stackitcloud/stackit-sdk-go/services/serviceenablement"
41-
enablementWait "github.com/stackitcloud/stackit-sdk-go/services/serviceenablement/wait"
40+
41+
serviceenablement "github.com/stackitcloud/stackit-sdk-go/services/serviceenablement/v2api"
42+
enablementWait "github.com/stackitcloud/stackit-sdk-go/services/serviceenablement/v2api/wait"
4243
legacySke "github.com/stackitcloud/stackit-sdk-go/services/ske"
4344
ske "github.com/stackitcloud/stackit-sdk-go/services/ske/v2api"
4445
skeWait "github.com/stackitcloud/stackit-sdk-go/services/ske/v2api/wait"
46+
4547
"golang.org/x/mod/semver"
4648

4749
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/conversion"
@@ -854,13 +856,13 @@ func (r *clusterResource) Create(ctx context.Context, req resource.CreateRequest
854856
}
855857

856858
// If SKE functionality is not enabled, enable it
857-
err := r.enablementClient.EnableServiceRegional(ctx, region, projectId, utils.SKEServiceId).Execute()
859+
err := r.enablementClient.DefaultAPI.EnableServiceRegional(ctx, region, projectId, utils.SKEServiceId).Execute()
858860
if err != nil {
859861
core.LogAndAddError(ctx, &resp.Diagnostics, "Error creating cluster", fmt.Sprintf("Calling API to enable SKE: %v", err))
860862
return
861863
}
862864

863-
_, err = enablementWait.EnableServiceWaitHandler(ctx, r.enablementClient, region, projectId, utils.SKEServiceId).WaitWithContext(ctx)
865+
_, err = enablementWait.EnableServiceWaitHandler(ctx, r.enablementClient.DefaultAPI, region, projectId, utils.SKEServiceId).WaitWithContext(ctx)
864866
if err != nil {
865867
core.LogAndAddError(ctx, &resp.Diagnostics, "Error creating cluster", fmt.Sprintf("Wait for SKE enablement: %v", err))
866868
return

stackit/internal/services/ske/ske_test.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@ import (
1010
"github.com/google/uuid"
1111
"github.com/hashicorp/terraform-plugin-testing/helper/resource"
1212
"github.com/hashicorp/terraform-plugin-testing/plancheck"
13-
"github.com/stackitcloud/stackit-sdk-go/services/serviceenablement"
13+
14+
serviceenablement "github.com/stackitcloud/stackit-sdk-go/services/serviceenablement/v2api"
15+
serviceenablementWait "github.com/stackitcloud/stackit-sdk-go/services/serviceenablement/v2api/wait"
1416
legacySke "github.com/stackitcloud/stackit-sdk-go/services/ske"
1517
ske "github.com/stackitcloud/stackit-sdk-go/services/ske/v2api"
1618

@@ -61,14 +63,14 @@ resource "stackit_ske_cluster" "cluster" {
6163
testutil.MockResponse{
6264
Description: "service enablement request",
6365
ToJsonBody: serviceenablement.ServiceStatus{
64-
State: new(serviceenablement.SERVICESTATUSSTATE_ENABLED),
66+
State: new(serviceenablementWait.SERVICESTATUSSTATE_ENABLED),
6567
},
6668
StatusCode: http.StatusOK,
6769
},
6870
testutil.MockResponse{
6971
Description: "service enablement wait handler",
7072
ToJsonBody: serviceenablement.ServiceStatus{
71-
State: new(serviceenablement.SERVICESTATUSSTATE_ENABLED),
73+
State: new(serviceenablementWait.SERVICESTATUSSTATE_ENABLED),
7274
Error: nil,
7375
},
7476
StatusCode: http.StatusOK,
@@ -256,14 +258,14 @@ resource "stackit_ske_cluster" "cluster" {
256258
testutil.MockResponse{
257259
Description: "service enablement request",
258260
ToJsonBody: serviceenablement.ServiceStatus{
259-
State: new(serviceenablement.SERVICESTATUSSTATE_ENABLED),
261+
State: new(serviceenablementWait.SERVICESTATUSSTATE_ENABLED),
260262
},
261263
StatusCode: http.StatusOK,
262264
},
263265
testutil.MockResponse{
264266
Description: "service enablement wait handler",
265267
ToJsonBody: serviceenablement.ServiceStatus{
266-
State: new(serviceenablement.SERVICESTATUSSTATE_ENABLED),
268+
State: new(serviceenablementWait.SERVICESTATUSSTATE_ENABLED),
267269
Error: nil,
268270
},
269271
StatusCode: http.StatusOK,

0 commit comments

Comments
 (0)