Reshape resource_acc_test

Author: Yago Carlos Fernandez Gou

stackit/internal/services/intake/resource_acc_test.go

@@ -0,0 +1,199 @@
+package intake_test
+
+import (
+	"context"
+	_ "embed"
+	"errors"
+	"fmt"
+	"maps"
+	"net/http"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-testing/config"
+	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
+	"github.com/hashicorp/terraform-plugin-testing/terraform"
+	sdkConfig "github.com/stackitcloud/stackit-sdk-go/core/config"
+	"github.com/stackitcloud/stackit-sdk-go/core/oapierror"
+	"github.com/stackitcloud/stackit-sdk-go/services/intake"
+	"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/testutil"
+)
+
+//go:embed testdata/resource-min.tf
+var resourceMin string
+
+//go:embed testdata/resource-max.tf
+var resourceMax string
+
+const intakeRunnerResource = "stackit_intake_runner.example"
+
+const (
+	intakeRunnerMinName        = "intake-min-runner"
+	intakeRunnerMinNameUpdated = "intake-min-runner-upd"
+	intakeRunnerMaxName        = "intake-max-runner"
+	intakeRunnerMaxNameUpdated = "intake-max-runner-upd"
+)
+
+var testConfigVarsMin = config.Variables{
+	"project_id": config.StringVariable(testutil.ProjectId),
+	"name":       config.StringVariable(intakeRunnerMinName),
+}
+
+var testConfigVarsMax = config.Variables{
+	"project_id": config.StringVariable(testutil.ProjectId),
+	"name":       config.StringVariable(intakeRunnerMaxName),
+}
+
+func testConfigVarsMinUpdated() config.Variables {
+	tempConfig := make(config.Variables, len(testConfigVarsMin))
+	maps.Copy(tempConfig, testConfigVarsMin)
+	tempConfig["name"] = config.StringVariable(intakeRunnerMinNameUpdated)
+	return tempConfig
+}
+
+func testConfigVarsMaxUpdated() config.Variables {
+	tempConfig := make(config.Variables, len(testConfigVarsMax))
+	maps.Copy(tempConfig, testConfigVarsMax)
+	tempConfig["name"] = config.StringVariable(intakeRunnerMaxNameUpdated)
+	return tempConfig
+}
+
+func TestAccIntakeRunnerMin(t *testing.T) {
+	resource.Test(t, resource.TestCase{
+		ProtoV6ProviderFactories: testutil.TestAccProtoV6ProviderFactories,
+		CheckDestroy:             testAccCheckIntakeRunnerDestroy,
+		Steps: []resource.TestStep{
+			// Create the minimum runner from the HCL file
+			{
+				ConfigVariables: testConfigVarsMin,
+				Config:          testutil.IntakeProviderConfig() + "\n" + resourceMin,
+				Check: resource.ComposeAggregateTestCheckFunc(
+					// Verify project_id, name and the existence of runner_id
+					resource.TestCheckResourceAttr(intakeRunnerResource, "project_id", testutil.ProjectId),
+					resource.TestCheckResourceAttr(intakeRunnerResource, "name", intakeRunnerMinName),
+					resource.TestCheckResourceAttrSet(intakeRunnerResource, "runner_id"),
+				),
+			},
+			// Data source check: creates config that includes resource and data source
+			{
+				ConfigVariables: testConfigVarsMin,
+				Config: fmt.Sprintf(`
+					%s
+					data "stackit_intake_runner" "example" {
+						project_id = %s.project_id
+						runner_id  = %s.runner_id
+						region     = %s.region
+					}`, testutil.IntakeProviderConfig()+"\n"+resourceMin, intakeRunnerResource, intakeRunnerResource, intakeRunnerResource),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					// Make sure it's correctly found resource by comparing runner_id attribute
+					resource.TestCheckResourceAttrPair(intakeRunnerResource, "runner_id", "data.stackit_intake_runner.example", "runner_id"),
+				),
+			},
+			// Simulate terraform import
+			{
+				ConfigVariables:   testConfigVarsMin,
+				Config:            testutil.IntakeProviderConfig() + "\n" + resourceMin,
+				ResourceName:      intakeRunnerResource,
+				ImportState:       true,
+				ImportStateVerify: true,
+				ImportStateIdFunc: func(s *terraform.State) (string, error) {
+					// Construct ID string
+					r, ok := s.RootModule().Resources[intakeRunnerResource]
+					if !ok {
+						return "", fmt.Errorf("couldn't find resource %s", intakeRunnerResource)
+					}
+					return fmt.Sprintf("%s,%s,%s", r.Primary.Attributes["project_id"], r.Primary.Attributes["region"], r.Primary.Attributes["runner_id"]), nil
+				},
+			},
+			// Update check: verifies API updated resource name without crashing
+			{
+				ConfigVariables: testConfigVarsMinUpdated(),
+				Config:          testutil.IntakeProviderConfig() + "\n" + resourceMin,
+				Check: resource.ComposeAggregateTestCheckFunc(
+					resource.TestCheckResourceAttr(intakeRunnerResource, "name", intakeRunnerMinNameUpdated),
+				),
+			},
+		},
+	})
+}
+
+func TestAccIntakeRunnerMax(t *testing.T) {
+	resource.Test(t, resource.TestCase{
+		ProtoV6ProviderFactories: testutil.TestAccProtoV6ProviderFactories,
+		CheckDestroy:             testAccCheckIntakeRunnerDestroy,
+		Steps: []resource.TestStep{
+			// Create the max intake runner from HCL files and verify comparison
+			{
+				ConfigVariables: testConfigVarsMax,
+				Config:          testutil.IntakeProviderConfig() + "\n" + resourceMax,
+				Check: resource.ComposeAggregateTestCheckFunc(
+					resource.TestCheckResourceAttr(intakeRunnerResource, "name", intakeRunnerMaxName),
+					resource.TestCheckResourceAttr(intakeRunnerResource, "description", "An example runner for Intake"),
+					resource.TestCheckResourceAttr(intakeRunnerResource, "max_message_size_kib", "1024"),
+				),
+			},
+			// Update and verify changes are reflected
+			{
+				ConfigVariables: testConfigVarsMaxUpdated(),
+				Config:          testutil.IntakeProviderConfig() + "\n" + resourceMax,
+				Check: resource.ComposeAggregateTestCheckFunc(
+					resource.TestCheckResourceAttr(intakeRunnerResource, "name", intakeRunnerMaxNameUpdated),
+				),
+			},
+		},
+	})
+}
+
+// testAccCheckIntakeRunnerDestroy act as independent auditor to verify destroy operation
+func testAccCheckIntakeRunnerDestroy(s *terraform.State) error {
+	// Create own raw API client
+	ctx := context.Background()
+	var client *intake.APIClient
+	var err error
+
+	// todo: check this again
+	effectiveRegion := testutil.Region
+	if effectiveRegion == "" {
+		effectiveRegion = "eu01"
+	}
+
+	if testutil.IntakeCustomEndpoint == "" {
+		client, err = intake.NewAPIClient(sdkConfig.WithRegion(effectiveRegion))
+	} else {
+		client, err = intake.NewAPIClient(
+			sdkConfig.WithEndpoint(testutil.IntakeCustomEndpoint),
+			sdkConfig.WithRegion(effectiveRegion),
+		)
+	}
+	if err != nil {
+		return fmt.Errorf("creating client: %w", err)
+	}
+
+	// Loop through resources that should have been deleted
+	for _, rs := range s.RootModule().Resources {
+		if rs.Type != "stackit_intake_runner" {
+			continue
+		}
+
+		pID := rs.Primary.Attributes["project_id"]
+		reg := rs.Primary.Attributes["region"]
+		rID := rs.Primary.Attributes["runner_id"]
+
+		// If it still exists, destroy operation was unsuccessful
+		_, err := client.GetIntakeRunner(ctx, pID, reg, rID).Execute()
+		if err == nil {
+			// Delete to prevent orphaned instances
+			errDel := client.DeleteIntakeRunner(ctx, pID, reg, rID).Execute()
+			if errDel != nil {
+				return fmt.Errorf("resource leaked and manual cleanup failed: %w", errDel)
+			}
+
+			return fmt.Errorf("intake runner %s still exists in region %s", rID, reg)
+		}
+
+		var oapiErr *oapierror.GenericOpenAPIError
+		if !errors.As(err, &oapiErr) || oapiErr.StatusCode != http.StatusNotFound {
+			return fmt.Errorf("unexpected error checking destruction: %w", err)
+		}
+	}
+	return nil
+}

stackit/internal/services/intake/runner/resource.go

@@ -501,14 +501,12 @@ func toUpdatePayload(model, state *Model) (*intake.UpdateIntakeRunnerPayload, er
 	payload.Description = conversion.StringValueToPointer(model.Description)
 
 	var labels map[string]string
-	if !model.Labels.IsUnknown() {
-		if !model.Labels.IsNull() {
-			diags := model.Labels.ElementsAs(context.Background(), &labels, false)
-			if diags.HasError() {
-				return nil, fmt.Errorf("failed to convert labels: %w", core.DiagsToError(diags))
-			}
-			payload.Labels = &labels
+	if !model.Labels.IsUnknown() && !model.Labels.IsNull() {
+		diags := model.Labels.ElementsAs(context.Background(), &labels, false)
+		if diags.HasError() {
+			return nil, fmt.Errorf("failed to convert labels: %w", core.DiagsToError(diags))
 		}
+		payload.Labels = &labels
 	}
 
 	return payload, nil

stackit/internal/services/intake/runner/resource_acc_test.go

@@ -0,0 +1,15 @@
+
+variable "project_id" {}
+variable "name" {}
+
+resource "stackit_intake_runner" "example" {
+    project_id              = var.project_id
+    name                    = var.name
+    description             = "An example runner for Intake"
+    max_message_size_kib    = 1024
+    max_messages_per_hour   = 1100
+    labels = {
+        "created_by" = "terraform-provider-stackit"
+        "env"        = "development"
+    }
+}