Skip to content

Commit dd3d63c

Browse files
author
Yago Carlos Fernandez Gou
committed
Remove replace directive during name change & complement test checks
1 parent dafb4a2 commit dd3d63c

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

stackit/internal/services/intake/resource_acc_test.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,11 @@ func TestAccIntakeRunnerMin(t *testing.T) {
7171
resource.TestCheckResourceAttr(intakeRunnerResource, "project_id", testutil.ProjectId),
7272
resource.TestCheckResourceAttr(intakeRunnerResource, "name", intakeRunnerMinName),
7373
resource.TestCheckResourceAttrSet(intakeRunnerResource, "runner_id"),
74+
resource.TestCheckResourceAttr(intakeRunnerResource, "max_message_size_kib", "1024"),
75+
resource.TestCheckResourceAttr(intakeRunnerResource, "max_messages_per_hour", "1000"),
76+
// Verify empty fields
77+
resource.TestCheckResourceAttr(intakeRunnerResource, "description", ""),
78+
resource.TestCheckResourceAttr(intakeRunnerResource, "labels.%", "0"),
7479
),
7580
},
7681
// Data source check: creates config that includes resource and data source
@@ -129,6 +134,11 @@ func TestAccIntakeRunnerMax(t *testing.T) {
129134
resource.TestCheckResourceAttr(intakeRunnerResource, "name", intakeRunnerMaxName),
130135
resource.TestCheckResourceAttr(intakeRunnerResource, "description", "An example runner for Intake"),
131136
resource.TestCheckResourceAttr(intakeRunnerResource, "max_message_size_kib", "1024"),
137+
resource.TestCheckResourceAttr(intakeRunnerResource, "max_messages_per_hour", "1100"),
138+
// Verify map size
139+
resource.TestCheckResourceAttr(intakeRunnerResource, "labels.%", "2"),
140+
resource.TestCheckResourceAttr(intakeRunnerResource, "labels.created_by", "terraform-provider-stackit"),
141+
resource.TestCheckResourceAttr(intakeRunnerResource, "labels.env", "development"),
132142
),
133143
},
134144
// Update and verify changes are reflected

stackit/internal/services/intake/runner/resource.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,9 +156,6 @@ func (r *runnerResource) Schema(_ context.Context, _ resource.SchemaRequest, res
156156
"name": schema.StringAttribute{
157157
Description: descriptions["name"],
158158
Required: true,
159-
PlanModifiers: []planmodifier.String{
160-
stringplanmodifier.RequiresReplace(),
161-
},
162159
},
163160
"description": schema.StringAttribute{
164161
Description: descriptions["description"],

0 commit comments

Comments
 (0)