Skip to content

Commit f94728b

Browse files
Marcel JacekMarcel Jacek
authored andcommitted
fix review findings
1 parent 2bf13c4 commit f94728b

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

docs/resources/loadbalancer.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ resource "stackit_network_interface" "nic" {
3535
network_id = stackit_network.example_network.network_id
3636
}
3737
38-
# Create a public IP for the load balance
38+
# Create a public IP for the load balancer
3939
resource "stackit_public_ip" "public-ip" {
4040
project_id = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
4141
lifecycle {

examples/resources/stackit_loadbalancer/resource.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ resource "stackit_network_interface" "nic" {
1616
network_id = stackit_network.example_network.network_id
1717
}
1818

19-
# Create a public IP for the load balance
19+
# Create a public IP for the load balancer
2020
resource "stackit_public_ip" "public-ip" {
2121
project_id = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
2222
lifecycle {

stackit/internal/services/loadbalancer/loadbalancer/datasource.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,22 +50,23 @@ func (r *loadBalancerDataSource) Configure(ctx context.Context, req datasource.C
5050
return
5151
}
5252

53-
providerData, ok := req.ProviderData.(core.ProviderData)
53+
var ok bool
54+
r.providerData, ok = req.ProviderData.(core.ProviderData)
5455
if !ok {
5556
core.LogAndAddError(ctx, &resp.Diagnostics, "Error configuring API client", fmt.Sprintf("Expected configure type stackit.ProviderData, got %T", req.ProviderData))
5657
return
5758
}
5859

5960
var apiClient *loadbalancer.APIClient
6061
var err error
61-
if providerData.LoadBalancerCustomEndpoint != "" {
62+
if r.providerData.LoadBalancerCustomEndpoint != "" {
6263
apiClient, err = loadbalancer.NewAPIClient(
63-
config.WithCustomAuth(providerData.RoundTripper),
64-
config.WithEndpoint(providerData.LoadBalancerCustomEndpoint),
64+
config.WithCustomAuth(r.providerData.RoundTripper),
65+
config.WithEndpoint(r.providerData.LoadBalancerCustomEndpoint),
6566
)
6667
} else {
6768
apiClient, err = loadbalancer.NewAPIClient(
68-
config.WithCustomAuth(providerData.RoundTripper),
69+
config.WithCustomAuth(r.providerData.RoundTripper),
6970
)
7071
}
7172

0 commit comments

Comments
 (0)