Skip to content

chore(kms): switch to new multi-API support SDK structure#1340

Merged
rubenhoenle merged 2 commits intomainfrom
chore/STACKITTPR-558-kms-sdk-migration
Mar 31, 2026
Merged

chore(kms): switch to new multi-API support SDK structure#1340
rubenhoenle merged 2 commits intomainfrom
chore/STACKITTPR-558-kms-sdk-migration

Conversation

@rubenhoenle
Copy link
Copy Markdown
Member

@rubenhoenle rubenhoenle commented Mar 31, 2026

Description

relates to STACKITTPR-558

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle rubenhoenle requested a review from a team as a code owner March 31, 2026 11:26
@rubenhoenle rubenhoenle force-pushed the chore/STACKITTPR-558-kms-sdk-migration branch from 600e5b2 to 09964fa Compare March 31, 2026 12:47
@rubenhoenle rubenhoenle enabled auto-merge (squash) March 31, 2026 13:07
@rubenhoenle rubenhoenle force-pushed the chore/STACKITTPR-558-kms-sdk-migration branch from 09964fa to 5ca6cdd Compare March 31, 2026 13:07
@rubenhoenle rubenhoenle merged commit b776e8c into main Mar 31, 2026
3 checks passed
@rubenhoenle rubenhoenle deleted the chore/STACKITTPR-558-kms-sdk-migration branch March 31, 2026 13:09
@github-actions
Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/key 11.76% (-0.40%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/keyring 9.04% (-1.55%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/utils 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/wrapping-key 12.77% (-1.74%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/key/datasource.go 0.00% (ø) 40 0 40
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/key/resource.go 14.97% (-0.47%) 147 (-2) 22 (-1) 125 (-1) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/keyring/datasource.go 0.00% (ø) 39 0 39
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/keyring/resource.go 11.81% (-1.93%) 127 (-4) 15 (-3) 112 (-1) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/utils/util.go 0.00% (ø) 8 0 8
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/wrapping-key/datasource.go 0.00% (ø) 40 0 40
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/wrapping-key/resource.go 16.22% (-2.08%) 148 (-5) 24 (-4) 124 (-1) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/key/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/keyring/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/kms_acc_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/kms/wrapping-key/resource_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants