Skip to content

chore(ske): switch to new SDK structure#1397

Merged
marceljk merged 2 commits intomainfrom
migrate-ske-sdk
Apr 21, 2026
Merged

chore(ske): switch to new SDK structure#1397
marceljk merged 2 commits intomainfrom
migrate-ske-sdk

Conversation

@marceljk
Copy link
Copy Markdown
Contributor

Description

relates to STACKITTPR-579

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk marceljk requested a review from a team as a code owner April 20, 2026 15:22
@marceljk marceljk force-pushed the migrate-ske-sdk branch 2 times, most recently from 64b30f5 to 5d47c3d Compare April 20, 2026 15:47
Comment thread stackit/internal/services/ske/cluster/resource.go Outdated
@marceljk marceljk enabled auto-merge (squash) April 21, 2026 15:26
@marceljk marceljk merged commit dcf6f21 into main Apr 21, 2026
3 checks passed
@marceljk marceljk deleted the migrate-ske-sdk branch April 21, 2026 15:30
@github-actions
Copy link
Copy Markdown

Merging this branch changes the coverage (2 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster 49.05% (-0.85%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/kubeconfig 25.42% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/provideroptions/kubernetesversions 41.18% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/provideroptions/machineimages 41.10% (-0.80%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/utils 85.71% (+10.71%) 🎉

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster/datasource.go 0.00% (ø) 39 0 39
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster/resource.go 51.29% (-0.81%) 852 (-27) 437 (-21) 415 (-6) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/kubeconfig/resource.go 25.42% (ø) 177 45 132
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/provideroptions/kubernetesversions/datasource.go 41.18% (ø) 68 28 40
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/provideroptions/machineimages/datasource.go 41.10% (-0.80%) 73 (-1) 30 (-1) 43 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/utils/util.go 85.71% (+10.71%) 14 (+6) 12 (+6) 2 🎉

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/kubeconfig/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/provideroptions/kubernetesversions/datasource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/provideroptions/machineimages/datasource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/utils/util_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants