Merged
Conversation
h3adex
force-pushed
the
feat/implement-sa-tokens
branch
11 times, most recently
from
629839a to
6f3b4e4
Compare
h3adex
requested review from
Fyusel,
bahkauv70,
marceljk and
rubenhoenle
as code owners
h3adex
force-pushed
the
feat/implement-sa-tokens
branch
7 times, most recently
from
9d06d7f to
30451ac
Compare
h3adex
force-pushed
the
feat/implement-sa-tokens
branch
from
30451ac to
cea1fad
Compare
h3adex
force-pushed
the
feat/implement-sa-tokens
branch
from
cea1fad to
f629b1f
Compare
Contributor
Author
|
Read for review :-) |
marceljk
reviewed
Mar 20, 2025
Contributor
marceljk
left a comment
marceljk
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Looks overall good and tested it already. Works very nice and I really like rotate_when_change part. Only a few minor things reading documation need to be adjusted
h3adex
force-pushed
the
feat/implement-sa-tokens
branch
from
3fc298b to
4a17da3
Compare
h3adex
force-pushed
the
feat/implement-sa-tokens
branch
from
4a17da3 to
9540c00
Compare
marceljk
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.