Merged
Conversation
h3adex
requested review from
Fyusel,
bahkauv70,
marceljk and
rubenhoenle
as code owners
h3adex
force-pushed
the
feat/implement-sa-keys-json-only
branch
10 times, most recently
from
bf4f48f to
a483239
Compare
Contributor
Author
|
Ready for review |
rubenhoenle
reviewed
Mar 21, 2025
Member
Also a general question / remark: Can you please link an GitHub issue or Jira issue which describes what you want to achieve within your PRs? You can also provide the information in the description of the PR for this time. |
h3adex
force-pushed
the
feat/implement-sa-keys-json-only
branch
from
a483239 to
6f736b6
Compare
h3adex
force-pushed
the
feat/implement-sa-keys-json-only
branch
2 times, most recently
from
6eb32f4 to
c6f03a8
Compare
h3adex
force-pushed
the
feat/implement-sa-keys-json-only
branch
from
c6f03a8 to
3b7f0ec
Compare
malteehrlen
reviewed
Mar 24, 2025
malteehrlen
reviewed
Mar 24, 2025
marceljk
reviewed
Mar 24, 2025
Contributor
marceljk
left a comment
marceljk
left a comment
There was a problem hiding this comment.
Looks mostly good only a few small things
h3adex
force-pushed
the
feat/implement-sa-keys-json-only
branch
from
7545496 to
9214630
Compare
marceljk
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a user, I want to be able to generate keys for a service account with customizable validity periods and signing options, so that I can choose between using a STACKIT certificate or a private RSA key for signing. The JSON response used to authenticate against the Stackit service should be available as a resource attribute.
Implementing data sources does not seem feasible in this case, since STACKIT does not store the private key itself. Consequently, a data source would lack important content.