Skip to content

Feat/stackittpr 196 ske improve acc test min/max config #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bahkauv70 merged 3 commits into from
May 27, 2025
Merged

Feat/stackittpr 196 ske improve acc test min/max config #851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6070be8
core(ske): first test working
bahkauv70 May 16, 2025
3b2d32f
chore(ske): acceptance test min
bahkauv70 May 19, 2025
ea7807c
chore(ske): implement review findings
bahkauv70 May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions stackit/internal/services/ske/cluster/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1407,13 +1407,13 @@ func mapFields(ctx context.Context, cl *ske.Cluster, m *Model, region string) er
return nil
}

func mapNodePools(ctx context.Context, cl *ske.Cluster, m *Model) error {
func mapNodePools(ctx context.Context, cl *ske.Cluster, model *Model) error {
modelNodePoolOSVersion := map[string]basetypes.StringValue{}
modelNodePoolOSVersionMin := map[string]basetypes.StringValue{}

modelNodePools := []nodePool{}
if !m.NodePools.IsNull() && !m.NodePools.IsUnknown() {
diags := m.NodePools.ElementsAs(ctx, &modelNodePools, false)
if !model.NodePools.IsNull() && !model.NodePools.IsUnknown() {
diags := model.NodePools.ElementsAs(ctx, &modelNodePools, false)
if diags.HasError() {
return core.DiagsToError(diags)
}
Expand All @@ -1428,7 +1428,7 @@ func mapNodePools(ctx context.Context, cl *ske.Cluster, m *Model) error {
}

if cl.Nodepools == nil {
m.NodePools = types.ListNull(types.ObjectType{AttrTypes: nodePoolTypes})
model.NodePools = types.ListNull(types.ObjectType{AttrTypes: nodePoolTypes})
return nil
}

Expand Down Expand Up @@ -1504,7 +1504,7 @@ func mapNodePools(ctx context.Context, cl *ske.Cluster, m *Model) error {
if diags.HasError() {
return core.DiagsToError(diags)
}
m.NodePools = nodePoolsTF
model.NodePools = nodePoolsTF
return nil
}

Expand Down
Loading