chore(terraform): use a util func to build internal terraform id#869
Merged
Conversation
4565d61 to
d22ac04
Compare
marceljk
reviewed
Jun 10, 2025
marceljk
left a comment
Contributor
There was a problem hiding this comment.
Looks good and makes it more readable!
I just found a few resources where the ID build can be adjusted:
d22ac04 to
6e2bf9a
Compare
marceljk
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of duplicating the code everywhere to build the internal terraform id for resource/datasource implementations, it's now a util func which can be called in a single line. Makes it much more easy to read IMO.
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)