Feat/implement advanced image search options#967
Merged
Fyusel merged 2 commits intoSep 2, 2025
Merged
Conversation
0390758 to
152f190
Compare
Contributor
Author
6bcb992 to
5b2b782
Compare
h3adex
commented
Aug 28, 2025
5b2b782 to
63f65f4
Compare
Fyusel
reviewed
Sep 1, 2025
Fyusel
left a comment
Contributor
There was a problem hiding this comment.
Looks good 😃 Only one nitpick
Signed-off-by: Mauritz Uphoff <mauritz.uphoff@stackit.cloud>
Signed-off-by: Mauritz Uphoff <mauritz.uphoff@stackit.cloud>
aa420f8 to
f466a37
Compare
Fyusel
approved these changes
Sep 2, 2025
Benjosh95
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR improves the
stackit_image_v2data source by enabling image selection via name, regex, or detailed filters (OS, distro, version, UEFI, and secure_boot). When multiple results match (e.g., Ubuntu 18.04, 20.04...), they are sorted descending by name, selecting the newest. Similar to Azure’s behavior.The design aligns with syntax and behavior from other providers like Azure, Google, and OpenStack.
Unlike Google/OpenStack, we avoid relying on
most_recentor timestamps (created_at,updated_at) since these refer to upload/update events—not actual image creation by the vendor. Instead, we sort by name/system version to reliably select the latest version.Code to test it:
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)