Skip to content

Commit 129a215

Browse files
rdimitrovclaude
andcommitted
Drop non-collaborator acknowledgment from PR body
Filtering out non-collaborator reviewers stays (prevents the 422 whole-call-failure). But mentioning them by name in the augmented PR body adds notification surface we don't want. Silently skip. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 564490a commit 129a215

1 file changed

Lines changed: 1 addition & 14 deletions

File tree

.github/workflows/upstream-release-docs.yml

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -384,31 +384,23 @@ jobs:
384384
# `gh pr edit --add-reviewer` call and drop the valid
385385
# reviewers along with the invalid ones. Community
386386
# contributors from the upstream repo often aren't
387-
# collaborators on docs-website; silently skip them rather
388-
# than ping or fail.
387+
# collaborators here; silently skip them.
389388
CANDIDATES=$(echo "$COMPARE" |
390389
grep -Ev '(\[bot\]$|^github-actions|^stacklokbot$|^dependabot|^renovate|^copilot)' || true)
391390
392391
REVIEWERS=""
393-
SKIPPED=""
394392
while IFS= read -r login; do
395393
[ -z "$login" ] && continue
396394
if gh api "repos/$REVIEW_REPO/collaborators/$login" --silent 2>/dev/null; then
397395
REVIEWERS="${REVIEWERS:+$REVIEWERS,}$login"
398-
else
399-
SKIPPED="${SKIPPED:+$SKIPPED, }$login"
400396
fi
401397
done <<< "$CANDIDATES"
402398
403399
# Cap at 5 to avoid review fatigue.
404400
REVIEWERS=$(echo "$REVIEWERS" | tr ',' '\n' | head -5 | paste -sd, -)
405401
406402
echo "list=$REVIEWERS" >> "$GITHUB_OUTPUT"
407-
echo "skipped=$SKIPPED" >> "$GITHUB_OUTPUT"
408403
echo "Reviewers: ${REVIEWERS:-<none>}"
409-
if [ -n "$SKIPPED" ]; then
410-
echo "Skipped non-collaborator contributors: $SKIPPED"
411-
fi
412404
413405
- name: Read docs_paths hint
414406
id: hints
@@ -597,7 +589,6 @@ jobs:
597589
GAPS_BLOCK: ${{ steps.signals.outputs.gaps_block }}
598590
AUTOGEN_NOTE: ${{ steps.autogen.outputs.note }}
599591
COMPARE_OK: ${{ steps.reviewers.outputs.compare_ok }}
600-
SKIPPED_REVIEWERS: ${{ steps.reviewers.outputs.skipped }}
601592
run: |
602593
START='<!-- upstream-release-docs:start -->'
603594
END='<!-- upstream-release-docs:end -->'
@@ -633,10 +624,6 @@ jobs:
633624
fi
634625
echo "Reviewers below are non-bot commit authors in the release range who are also collaborators on this repo."
635626
echo ""
636-
if [ -n "$SKIPPED_REVIEWERS" ]; then
637-
echo "Other release contributors (not assigned as reviewers because they aren't repo collaborators): $SKIPPED_REVIEWERS. Thanks for the contribution!"
638-
echo ""
639-
fi
640627
echo "$END"
641628
} > /tmp/section.md
642629

0 commit comments

Comments
 (0)