Skip to content

Commit 45887a5

Browse files
ChrisJBurnsclaude
andcommitted
Address editorial review feedback
- Replace em dash with hyphen in telemetry caBundleRef note - Fix ambiguous "Both X and Y cannot" phrasing for authServerRef - Add MCPServerEntry to MCPGroup description paragraph - Align comparison table to parallel noun phrase structure Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 13b8887 commit 45887a5

3 files changed

Lines changed: 12 additions & 12 deletions

File tree

docs/toolhive/guides-k8s/auth-k8s.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -676,9 +676,9 @@ spec:
676676
issuer: 'https://mcp.example.com'
677677
```
678678

679-
Both `authServerRef` and `externalAuthConfigRef` cannot point to an
680-
`embeddedAuthServer` type simultaneously. The same `authServerRef` field is
681-
available on MCPRemoteProxy resources.
679+
`authServerRef` and `externalAuthConfigRef` cannot both reference an
680+
`embeddedAuthServer` type. The same `authServerRef` field is available on
681+
MCPRemoteProxy resources.
682682

683683
:::
684684

docs/toolhive/guides-k8s/telemetry-and-metrics.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ spec:
175175

176176
:::note
177177

178-
`caBundleRef` cannot be used when `insecure` is set to `true` they are
178+
`caBundleRef` cannot be used when `insecure` is set to `true` - they are
179179
mutually exclusive.
180180

181181
:::

docs/toolhive/guides-vmcp/configuration.mdx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ VirtualMCPServer resource. For a complete field reference, see the
1111

1212
Before creating a VirtualMCPServer, you need an
1313
[MCPGroup](../reference/crd-spec.md#apiv1alpha1mcpgroup) to organize the backend
14-
MCP servers. An MCPGroup is a logical container that groups related MCPServer
15-
and MCPRemoteProxy resources together.
14+
MCP servers. An MCPGroup is a logical container that groups related MCPServer,
15+
MCPRemoteProxy, and MCPServerEntry resources together.
1616

1717
Create a basic MCPGroup:
1818

@@ -140,12 +140,12 @@ spec:
140140

141141
**When to use MCPServerEntry vs. MCPRemoteProxy:**
142142

143-
| | MCPServerEntry | MCPRemoteProxy |
144-
| ------------------- | -------------------------------------------------------------- | --------------------------------------------------------------------------------- |
145-
| **Infrastructure** | No pods, services, or deployments | Creates a proxy pod and service |
146-
| **Use case** | Lightweight catalog entries for well-known remote servers | When you need request transformation, caching, or the full proxy middleware chain |
147-
| **Discovery** | Discovered by VirtualMCPServer through MCPGroup membership | Discovered by VirtualMCPServer through MCPGroup membership |
148-
| **SSRF protection** | Built-in URL validation blocks internal and metadata endpoints | N/A (proxy runs inside the cluster) |
143+
| | MCPServerEntry | MCPRemoteProxy |
144+
| ------------------- | -------------------------------------------------------------- | ------------------------------------------------------------------------------------------- |
145+
| **Infrastructure** | No pods, services, or deployments | Creates a proxy pod and service |
146+
| **Use case** | Lightweight catalog entries for well-known remote servers | Proxied connections requiring request transformation, caching, or the full middleware chain |
147+
| **Discovery** | Discovered by VirtualMCPServer through MCPGroup membership | Discovered by VirtualMCPServer through MCPGroup membership |
148+
| **SSRF protection** | Built-in URL validation blocks internal and metadata endpoints | N/A (proxy runs inside the cluster) |
149149

150150
:::note
151151

0 commit comments

Comments
 (0)