Skip to content

Commit 9c91cfa

Browse files
rdimitrovclaude
authored andcommitted
Fix review findings: StatefulSet→Deployment, redundant paragraph, nits
- Align MCPServer backend workload type with CRD reference (Deployment, not StatefulSet) - Remove redundant closing paragraph in scaling guide - Add Redis address comment in vMCP scaling example - Use precise CRD description for forEach collection field Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 2e365ba commit 9c91cfa

3 files changed

Lines changed: 7 additions & 10 deletions

File tree

docs/toolhive/guides-k8s/run-mcp-k8s.mdx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -443,8 +443,8 @@ kubectl -n <NAMESPACE> describe mcpserver <NAME>
443443

444444
## Horizontal scaling
445445

446-
MCPServer creates two separate workloads: a proxy runner Deployment and a
447-
backend MCP server StatefulSet. You can scale each independently:
446+
MCPServer creates two separate Deployments: a proxy runner and a backend MCP
447+
server. You can scale each independently:
448448

449449
- `spec.replicas` controls the proxy runner pod count
450450
- `spec.backendReplicas` controls the backend MCP server pod count
@@ -459,7 +459,7 @@ Common configurations:
459459
auth and connection overhead is the bottleneck with a single backend.
460460
- **Scale only the backend** (omit `replicas`, `backendReplicas: M`): useful
461461
when tool execution is CPU/memory-bound and the proxy is not a bottleneck. The
462-
backend StatefulSet uses client-IP session affinity to route repeated
462+
backend Deployment uses client-IP session affinity to route repeated
463463
connections to the same pod - subject to the same NAT limitations as
464464
proxy-level affinity.
465465
- **Scale both** (`replicas: N`, `backendReplicas: M`): full horizontal scale.
@@ -512,7 +512,7 @@ spec:
512512
terminationGracePeriodSeconds: 60
513513
```
514514

515-
The same 30-second default applies to the backend StatefulSet.
515+
The same 30-second default applies to the backend Deployment.
516516

517517
:::
518518

docs/toolhive/guides-vmcp/composite-tools.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -389,11 +389,11 @@ spec:
389389

390390
| Field | Description | Default |
391391
| --------------- | ----------------------------------------------------- | ------- |
392-
| `collection` | Template expression that produces an array | — |
392+
| `collection` | Template expression that resolves to a JSON array | - |
393393
| `itemVar` | Variable name for the current item | item |
394394
| `maxParallel` | Maximum concurrent iterations (max 50) | 10 |
395395
| `maxIterations` | Maximum total iterations (max 1000) | 100 |
396-
| `step` | Inner step definition (tool call to execute per item) | |
396+
| `step` | Inner step definition (tool call to execute per item) | - |
397397
| `onError` | Error handling: `abort` (stop) or `continue` (skip) | abort |
398398

399399
:::note

docs/toolhive/guides-vmcp/scaling-and-performance.mdx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ spec:
7575
replicas: 3
7676
sessionStorage:
7777
provider: redis
78-
address: redis-master.toolhive-system.svc.cluster.local:6379
78+
address: redis-master.toolhive-system.svc.cluster.local:6379 # Update to match your Redis Service location
7979
db: 0
8080
keyPrefix: vmcp-sessions
8181
passwordRef:
@@ -134,9 +134,6 @@ a dedicated vMCP instance per team instead.
134134

135135
:::
136136

137-
For stateful backends, vertical scaling or dedicated instances per team/use case
138-
are recommended instead of horizontal scaling.
139-
140137
## Next steps
141138

142139
- [Explore Kubernetes operator guides](../guides-k8s/index.mdx) for managing MCP

0 commit comments

Comments
 (0)