Skip to content

Commit bc0e5f4

Browse files
jhrozekclaude
authored andcommitted
Address PR feedback: fix placeholder and remove redirect
Replace <REDIS_ACL_PASSWORD> with YOUR_REDIS_ACL_PASSWORD (no angle brackets) to avoid confusing ><PLACEHOLDER> syntax in Redis ACL entries. Remove unused vercel.json redirect since the page was never published at the old integrations/ path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent abfa020 commit bc0e5f4

3 files changed

Lines changed: 12 additions & 14 deletions

File tree

docs/toolhive/guides-k8s/auth-k8s.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,7 @@ Create the Secret containing your Redis ACL credentials:
558558
kubectl create secret generic redis-acl-secret \
559559
--namespace toolhive-system \
560560
--from-literal=username=toolhive-auth \
561-
--from-literal=password="<REDIS_ACL_PASSWORD>"
561+
--from-literal=password="YOUR_REDIS_ACL_PASSWORD"
562562
```
563563

564564
For a complete walkthrough including deploying Redis Sentinel from scratch, see

docs/toolhive/guides-k8s/redis-session-storage.mdx

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,17 +46,19 @@ The ACL Secret defines a `toolhive-auth` user with permissions restricted to the
4646
copies the ACL file into the Redis data directory so it persists across
4747
restarts.
4848

49-
:::tip
49+
:::tip[Generate a strong ACL password]
5050

51-
Replace `<REDIS_ACL_PASSWORD>` in the ACL Secret below with a strong, randomly
52-
generated password. You can generate one with:
51+
Generate a random password and use it in the ACL Secret and Kubernetes Secret
52+
below:
5353

5454
```bash
5555
openssl rand -base64 32
5656
```
5757

58-
In the ACL entry, the `>` character before the password is Redis ACL syntax
59-
meaning "set password to"—it is not part of the placeholder.
58+
In the ACL entry, the `>` prefix before the password is
59+
[Redis ACL syntax](https://redis.io/docs/latest/operate/oss_and_stack/management/security/acl/#acl-rules)
60+
meaning "set this user's password." Replace `YOUR_REDIS_ACL_PASSWORD` with the
61+
generated value.
6062

6163
:::
6264

@@ -71,8 +73,9 @@ type: Opaque
7173
stringData:
7274
# highlight-start
7375
users.acl: >-
74-
user toolhive-auth on ><REDIS_ACL_PASSWORD> ~thv:auth:* &* +GET +SET +SETNX
75-
+DEL +EXISTS +EXPIRE +SADD +SREM +SMEMBERS +EVAL +MULTI +EXEC +EVALSHA +PING
76+
user toolhive-auth on >YOUR_REDIS_ACL_PASSWORD ~thv:auth:* &* +GET +SET
77+
+SETNX +DEL +EXISTS +EXPIRE +SADD +SREM +SMEMBERS +EVAL +MULTI +EXEC
78+
+EVALSHA +PING
7679
# highlight-end
7780
---
7881
# --- Redis headless Service
@@ -290,7 +293,7 @@ The username and password must match the ACL user defined above:
290293
kubectl create secret generic redis-acl-secret \
291294
--namespace toolhive-system \
292295
--from-literal=username=toolhive-auth \
293-
--from-literal=password="<REDIS_ACL_PASSWORD>"
296+
--from-literal=password="YOUR_REDIS_ACL_PASSWORD"
294297
```
295298

296299
## Configure MCPExternalAuthConfig

vercel.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
{
22
"$schema": "https://openapi.vercel.sh/vercel.json",
33
"redirects": [
4-
{
5-
"source": "/toolhive/integrations/redis-session-storage",
6-
"destination": "/toolhive/guides-k8s/redis-session-storage",
7-
"permanent": true
8-
},
94
{
105
"source": "/toolhive/quickstart",
116
"destination": "/toolhive/guides-cli/quickstart",

0 commit comments

Comments
 (0)