Skip to content

Commit d289ce2

Browse files
jhrozekclaude
andcommitted
Address two Copilot review comments on PR #681
- Line 22: add signature/introspection to diagram token validation node to match prose description of JWT and opaque token paths - Line 48: replace inaccurate blanket audience requirement with accurate distinction: required for oidcConfigRef, optional for inline OIDC Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 91419f4 commit d289ce2

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

docs/toolhive/guides-vmcp/authentication.mdx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ flowchart LR
1919
2020
subgraph vMCP["Virtual MCP Server (vMCP)"]
2121
direction TB
22-
Auth["Token validation<br>(issuer, audience, expiry)"]
22+
Auth["Token validation<br>(issuer, audience, expiry,<br>signature/introspection)"]
2323
Authz["Authorization<br>(Cedar policies)"]
2424
Proxy[Backend proxy]
2525
Auth --> Authz --> Proxy
@@ -44,8 +44,10 @@ The vMCP validates the token — checking issuer, audience, expiry, and signatur
4444
for JWTs, or using token introspection for opaque tokens — and then evaluates
4545
Cedar policies before forwarding the request. This all happens inside the single
4646
`vmcp` process, unlike a plain MCPServer deployment where a separate ToolHive
47-
proxy handles this step. The audience value must be explicitly set in
48-
`incomingAuth` (see [OIDC authentication](#oidc-authentication) below).
47+
proxy handles this step. When using shared OIDC configuration via
48+
`oidcConfigRef`, the audience value must be explicitly set. For inline OIDC
49+
configuration, it is optional but recommended. See
50+
[OIDC authentication](#oidc-authentication) below.
4951

5052
**Boundary 2 (Outgoing):** vMCP obtains credentials for each backend API using
5153
the configured outgoing auth strategy. See

0 commit comments

Comments
 (0)