Conversation
- Add thv skill builds and thv skill builds remove guide content to skills-management.mdx with example output and CLI reference link - Fix MCPOIDCConfig status column name READY → VALID in auth-k8s.mdx (breaking change in v0.16.0: condition type renamed for consistency) - Document MCPServerEntry CRD in K8s intro with note that controller ships in a future release - Clarify VirtualMCPServer Redis session storage enables cross-pod restore and survives pod restarts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
The thv skill builds section and the READY → VALID fix look good. Two things to address:
Cut MCPServerEntry until the controller ships (see inline comment)
Redundant paragraph in Redis session storage section
In scaling-and-performance.mdx, the updated opening sentence already covers the new capability ("sessions are shared across pods and survive pod restarts"), and the "without" sentence reinforces it from the negative side. The added paragraph ("With Redis session storage configured, vMCP stores session state in Redis so that any replica can resume a session, even after a pod restart or failover.") restates the same point. Cut it.
Also, the lint/formatting checks are failing and will need to be addressed. Pre-commit hook should have taken care of this if you have nodejs installed (or use the devcontainer).
| :::note | ||
|
|
||
| `MCPServerEntry` is a new resource type added in v0.16.0. The CRD is available | ||
| and you can create resources, but the reconciliation controller ships in a | ||
| future release. Creating `MCPServerEntry` resources before the controller is | ||
| available has no effect — the operator will not reconcile them until the | ||
| controller ships. | ||
|
|
||
| ::: | ||
|
|
There was a problem hiding this comment.
So why even document it at this point? Hold off until it's ready to use?
|
|
||
| - [Understanding skills](../concepts/skills.mdx) for a conceptual overview | ||
| - [`thv skill` command reference](../reference/cli/thv_skill.md) | ||
| - [`thv skill builds` command reference](../reference/cli/thv_skill_builds.md) |
There was a problem hiding this comment.
No need to add a specific subcommand reference, it's covered by the one above and none of the others are individually linked.
| - [`thv skill builds` command reference](../reference/cli/thv_skill_builds.md) |
| TAG DIGEST NAME VERSION | ||
| ghcr.io/my-org/skills/my-skill:v1.0.0 sha256:a1b2c3d4... my-skill 1.0.0 | ||
| my-skill:latest sha256:e5f6a7b8... my-skill |
There was a problem hiding this comment.
Alignment issue?
| TAG DIGEST NAME VERSION | |
| ghcr.io/my-org/skills/my-skill:v1.0.0 sha256:a1b2c3d4... my-skill 1.0.0 | |
| my-skill:latest sha256:e5f6a7b8... my-skill | |
| TAG DIGEST NAME VERSION | |
| ghcr.io/my-org/skills/my-skill:v1.0.0 sha256:a1b2c3d4... my-skill 1.0.0 | |
| my-skill:latest sha256:e5f6a7b8... my-skill |
|
@claude are all the comments addressed? |
|
Claude finished @reyortiz3's task in 1m 11s —— View job Review comment statusHere's the status of each review comment from @danbarr:
Details1. Cut MCPServerEntry — The 2. Redundant paragraph in
This needs to be removed since the opening sentence (lines 69–72) already covers the same information. 3. The suggestion was to remove it (empty suggestion block = deletion). 4. Alignment issue — The first data row in the builds output example is still misaligned. The tag None of the four inline/review comments appear to have been addressed yet in the current branch state. |
2 participants
Description
This PR updates the user-facing documentation to reflect the non-reference
changes in ToolHive v0.16.0. Reference docs (CLI commands, CRD spec, API spec)
were already updated automatically in #678.
Type of change
Changes
thv skill builds/thv skill builds remove(guides-cli/skills-management.mdx)thv skill builds(list) andthv skill builds remove <tag>(remove), withexample output and a link to the CLI reference.
MCPOIDCConfig
VALIDcolumn (guides-k8s/auth-k8s.mdx)READYtoVALID. This was a breakingchange in v0.16.0: the condition type was renamed for consistency with the
other config CRDs.
MCPServerEntry CRD (
guides-k8s/intro.mdx)MCPServerEntryto the workload resource table and updated theintroductory prose to mention the new CRD type.
reconciliation controller ships in a future release.
VirtualMCPServer Redis session storage (
guides-vmcp/scaling-and-performance.mdx)session restore and sessions survive pod restarts (new capability in v0.16.0
via PR #4479 upstream).
Related issues/PRs
thv skill builds: Add thv skill builds command to list locally-built OCI artifacts toolhive#4499, Add thv skill builds command to list and remove locally-built OCI skill artifacts toolhive#4674Submitter checklist
Content and formatting
🤖 Generated with Claude Code