Skip to content

Commit ed276b4

Browse files
JAORMXclaude
andcommitted
Fix CI lint job by using golangci-lint-action
The lint job failed because golangci-lint was not installed on the runner. Replace the manual Task-based approach with the standard golangci/golangci-lint-action which handles installation and caching. Set CGO_ENABLED=0 so CGO-only packages are excluded, and add the missing cgo build constraint to propolis-runner/main.go so it is correctly skipped when CGO is disabled. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 862f07f commit ed276b4

2 files changed

Lines changed: 8 additions & 7 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,12 @@ jobs:
4646
go-version: ${{ env.GO_VERSION }}
4747
cache: true
4848

49-
- name: Install Task
50-
run: |
51-
sh -c "$(curl --location https://taskfile.dev/install.sh)" -- -d -b /usr/local/bin
52-
53-
- name: Run linter
54-
run: |
55-
task lint
49+
- name: Run golangci-lint
50+
uses: golangci/golangci-lint-action@v7
51+
with:
52+
args: --timeout=5m
53+
env:
54+
CGO_ENABLED: "0"
5655

5756
build:
5857
name: Build

runner/cmd/propolis-runner/main.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
// SPDX-FileCopyrightText: Copyright 2025 Stacklok, Inc.
22
// SPDX-License-Identifier: Apache-2.0
33

4+
//go:build (linux || darwin) && cgo
5+
46
// Package main provides the propolis-runner helper binary.
57
// This binary is spawned as a subprocess by the propolis framework
68
// to run VMs using libkrun's CGO bindings.

0 commit comments

Comments
 (0)