Fix macOS runner dylib install name for portable bundles#15
Merged
Conversation
Homebrew bakes an absolute path (/opt/homebrew/opt/libkrun/lib/libkrun.1.dylib) into the runner's Mach-O load command. When the runner is extracted from an embedded bundle into a cache directory, dyld fails to find libkrun.1.dylib because the shipped file is named libkrun.dylib. Use install_name_tool to rewrite the load command to @loader_path/libkrun.dylib during build-runner-darwin, then re-codesign since install_name_tool invalidates the signature. Also use cp -f to handle read-only Homebrew dylibs on rebuild. Fixes #14 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JAORMX
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@loader_path/libkrun.dylibusinginstall_name_toolinbuild-runner-darwininstall_name_toolinvalidates the Mach-O signature)cp -ffor dylib copies to handle read-only files on rebuildTest plan
task build-runner-darwinsucceedsotool -L bin/propolis-runner | grep krunshows@loader_path/libkrun.dylib~/.cache/broodbox/runtime/— dyld no longer errors onlibkrun.1.dylibFixes #14
🤖 Generated with Claude Code