Skip to content

Fix macOS runner dylib install name for portable bundles #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JAORMX merged 1 commit into from
Mar 5, 2026
Merged

Fix macOS runner dylib install name for portable bundles #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions Taskfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ vars:
BUILDER_IMAGE: ghcr.io/stacklok/propolis-builder
LIBKRUN_VERSION:
sh: grep '^LIBKRUN_VERSION=' versions.env | cut -d= -f2
LIBKRUN_MAJOR:
sh: grep '^LIBKRUN_VERSION=' versions.env | cut -d= -f2 | sed 's/^v//' | cut -d. -f1
BUILDER_IMAGE_TAG: '{{.LIBKRUN_VERSION}}'

# Quick reference:
Expand Down Expand Up @@ -73,8 +75,16 @@ tasks:
platforms: [darwin]
cmds:
- task: build-dev-darwin
- cp $(brew --prefix libkrun)/lib/libkrun.dylib bin/
- cp $(brew --prefix libkrunfw)/lib/libkrunfw.dylib bin/
- cp -f $(brew --prefix libkrun)/lib/libkrun.dylib bin/
- cp -f $(brew --prefix libkrunfw)/lib/libkrunfw.dylib bin/
# Rewrite absolute Homebrew install name to @loader_path for portable bundles
- >-
install_name_tool -change
/opt/homebrew/opt/libkrun/lib/libkrun.{{.LIBKRUN_MAJOR}}.dylib
@loader_path/libkrun.dylib
bin/{{.RUNNER_NAME}}
# Re-sign after binary modification (install_name_tool invalidates signature)
- codesign --entitlements assets/entitlements.plist --force -s - bin/{{.RUNNER_NAME}}
generates:
- bin/{{.RUNNER_NAME}}
- bin/libkrun.dylib
Expand Down